Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding serialization support to be used for GT-SFM #650

Merged
merged 10 commits into from
Jan 4, 2021
Merged

Adding serialization support to be used for GT-SFM #650

merged 10 commits into from
Jan 4, 2021

Conversation

ayushbaid
Copy link
Contributor

GT-SFM project uses the SfmData and SfmTrack structures. Hence, this PR adds serialization support to these two structures.

ayushbaid
ayushbaid commented Jan 2, 2021
View reviewed changes
gtsam/slam/dataset.h Outdated
#include <gtsam/base/types.h>


#include <boost/serialization/vector.hpp>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is used to serialize vectors

ayushbaid
ayushbaid commented Jan 2, 2021
View reviewed changes
gtsam/slam/dataset.h Outdated Show resolved Hide resolved
@ayushbaid ayushbaid added enhancement Improvement to GTSAM help wanted Need help and/or clarification labels Jan 2, 2021
@ayushbaid
Copy link
Contributor Author

Also, the python wrapper build fails. @ProfFan, can you suggest me why this is happening?

@ProfFan
Copy link
Collaborator

ProfFan commented Jan 2, 2021

Maybe, look at the generated code in gtsam.cpp and write a similar unit test in C++ for SFMTrack serialization first?

@ayushbaid ayushbaid added quick-review Quick and easy PR to review and removed help wanted Need help and/or clarification labels Jan 3, 2021
@ayushbaid
Copy link
Contributor Author

Maybe, look at the generated code in gtsam.cpp and write a similar unit test in C++ for SFMTrack serialization first?

Works now!

dellaert
dellaert approved these changes Jan 3, 2021
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!! You nailed it :-)

@ayushbaid ayushbaid merged commit 5333396 into develop Jan 4, 2021
@johnwlambert johnwlambert deleted the feature/sfm-serialization branch January 5, 2021 05:14
@johnwlambert johnwlambert mentioned this pull request Jan 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnwlambert johnwlambert johnwlambert approved these changes

@dellaert dellaert dellaert approved these changes

@ProfFan ProfFan Awaiting requested review from ProfFan

Assignees
No one assigned
Labels
enhancement Improvement to GTSAM quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayushbaid @ProfFan @dellaert @johnwlambert