Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonized error/logProbability in entire Factor/Conditional hierarchy #1380

Merged
merged 21 commits into from
Jan 12, 2023
Merged

Harmonized error/logProbability in entire Factor/Conditional hierarchy #1380

merged 21 commits into from
Jan 12, 2023

Commits on Jan 10, 2023

  1. Added nonlinear Values

    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    e0a40b3 View commit details
    Browse the repository at this point in the history

  2. Added better docs

    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    aed576c View commit details
    Browse the repository at this point in the history

  3. Declared and defined error method in Factor, getting rid of logDensit… 

    …y, as error is now unambiguously defined as -logDensity in conditional factors.
    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    877e564 View commit details
    Browse the repository at this point in the history

  4. Fixed tests to work with new definition of error.

    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    4858e39 View commit details
    Browse the repository at this point in the history

  5. small doc edits

    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    f6d7be9 View commit details
    Browse the repository at this point in the history

  6. Fixed discrete classes.

    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    58bc4b6 View commit details
    Browse the repository at this point in the history

  7. Easier scheme for error(HybridValues)

    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    b4706be View commit details
    Browse the repository at this point in the history

  8. Moved factor graph error(HybridValues) to FactorGraph base class.

    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    83bae7d View commit details
    Browse the repository at this point in the history

  9. Fix dogleg unit test (gbn error != linearized error anymore)

    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    69398d0 View commit details
    Browse the repository at this point in the history

  10. Added logProbability/evaluate in conditionals/Bayes net

    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    8e29140 View commit details
    Browse the repository at this point in the history

  11. Implemented all Gaussian versions of logProbability

    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    ecb0be4 View commit details
    Browse the repository at this point in the history

  12. Symbolic logProbability just throws

    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    b7fbe3f View commit details
    Browse the repository at this point in the history

  13. Fix sign issue and added test

    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    2865849 View commit details
    Browse the repository at this point in the history

  14. Fix linking error

    @dellaert
    dellaert committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    f89ef73 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. discrete now has all logProbability and evaluate versions needed.

    @dellaert
    dellaert committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    11ef99b View commit details
    Browse the repository at this point in the history

  2. Endowed hybrid with logProbability

    @dellaert
    dellaert committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    426a49d View commit details
    Browse the repository at this point in the history

  3. Added missing methods

    @dellaert
    dellaert committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    eb37d08 View commit details
    Browse the repository at this point in the history

  4. Wrapper and tests for logProbability

    @dellaert
    dellaert committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    87ff4af View commit details
    Browse the repository at this point in the history

  5. Don't use deprecated method.

    @dellaert
    dellaert committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    4340b46 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Resolved review comments.

    @dellaert
    dellaert committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    28f440a View commit details
    Browse the repository at this point in the history

  2. Return a set of DiscreteKey, Fixes issue #1384

    @dellaert
    dellaert committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    f4c3131 View commit details
    Browse the repository at this point in the history