Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonized error/logProbability in entire Factor/Conditional hierarchy #1380

Merged
merged 21 commits into from
Jan 12, 2023

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Jan 11, 2023

Cleaning up before releasing 4.2 and implementing last hybrid PR

  • renamed logDensity to logProbability, as density is continuous only
  • we now have logProbability(x) = log(evaluate(x)) = K - error(x) for all conditionals
  • probPrime(x) = exp(-error(x)) as always, but is only supposed to be used in factors

My advice for reviewing (seems daunting but most is rote):

  • start with Factor.h, Conditional.h and the rest of inference - read the updated docs (and please flag issues).
  • Then hybrid.
  • Then linear, discrete, symbolic

Note that some methods are gone as now implemented in bottom base classes.

@dellaert dellaert requested a review from ProfFan January 11, 2023 07:57
Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most looks great to me!

gtsam/symbolic/SymbolicConditional.h Show resolved Hide resolved
gtsam/hybrid/HybridBayesNet.cpp Outdated Show resolved Hide resolved
gtsam/hybrid/HybridValues.h Show resolved Hide resolved
gtsam/inference/BayesNet.h Show resolved Hide resolved
python/gtsam/tests/test_DiscreteBayesNet.py Show resolved Hide resolved
python/gtsam/tests/test_GaussianBayesNet.py Outdated Show resolved Hide resolved
@dellaert dellaert merged commit a34c463 into develop Jan 12, 2023
@dellaert dellaert deleted the feature/uniform_error branch January 12, 2023 15:48
@dellaert dellaert added this to the Hybrid Inference milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants