Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper Hybrid Elimination #1319

Merged
merged 63 commits into from
Dec 30, 2022
Merged

Proper Hybrid Elimination #1319

merged 63 commits into from
Dec 30, 2022

Commits on Oct 25, 2022

  1. minor typo fixes

    @varunagrawal
    varunagrawal committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    0839331 View commit details
    Browse the repository at this point in the history

  2. remove if guards and add timing counters

    @varunagrawal
    varunagrawal committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    7dec7bb View commit details
    Browse the repository at this point in the history

  3. new WIP test to check the discrete probabilities after elimination

    @varunagrawal
    varunagrawal committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    dcdcf30 View commit details
    Browse the repository at this point in the history

  4. showing difference in computed probabilities

    @varunagrawal
    varunagrawal committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    1789bb7 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Increase the number of time steps for incremental test case

    @varunagrawal
    varunagrawal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    96afdff View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Merge branch 'hybrid/error' into hybrid/tests

    @varunagrawal
    varunagrawal committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    5bfce89 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Merge branch 'hybrid/error' into hybrid/tests

    @varunagrawal
    varunagrawal committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    a97d27e View commit details
    Browse the repository at this point in the history

  2. fix hybrid elimination

    @varunagrawal
    varunagrawal committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    a6d1a57 View commit details
    Browse the repository at this point in the history

  3. figured out how to get the correct continuous errors

    @varunagrawal
    varunagrawal committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    2f2f8c9 View commit details
    Browse the repository at this point in the history

  4. allow optional discrete transition probability for Switching test fix… 

    …ture
    @varunagrawal
    varunagrawal committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    98febf2 View commit details
    Browse the repository at this point in the history

  5. set up unit test to verify that the probPrimeTree has the same values… 

    … as individual factor graphs
    @varunagrawal
    varunagrawal committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    610a535 View commit details
    Browse the repository at this point in the history

  6. add methods to perform correct elimination

    @varunagrawal
    varunagrawal committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    1815433 View commit details
    Browse the repository at this point in the history

  7. update HybridSmoother to use the new method

    @varunagrawal
    varunagrawal committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    090cc42 View commit details
    Browse the repository at this point in the history

  8. use long sequence in HybridEstimation test

    @varunagrawal
    varunagrawal committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    083fd21 View commit details
    Browse the repository at this point in the history

  9. add docs

    @varunagrawal
    varunagrawal committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    64cd7c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. add optional ordering and fix bug

    @varunagrawal
    varunagrawal committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    3987b03 View commit details
    Browse the repository at this point in the history

  2. minor clean up and get tests to pass

    @varunagrawal
    varunagrawal committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    1a3b343 View commit details
    Browse the repository at this point in the history

  3. update test in testHybridEstimation

    @varunagrawal
    varunagrawal committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    1b168ce View commit details
    Browse the repository at this point in the history

  4. separate HybridGaussianFactorGraph::error() using both continuous and… 

    … discrete values
    @varunagrawal
    varunagrawal committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    cb55af3 View commit details
    Browse the repository at this point in the history

  5. add HybridGaussianFactorGraph::probPrime method

    @varunagrawal
    varunagrawal committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    eb94ad9 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. overload multifrontal elimination

    @varunagrawal
    varunagrawal committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    0938159 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. add copy constructor for HybridBayesTreeClique

    @varunagrawal
    varunagrawal committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    98d3186 View commit details
    Browse the repository at this point in the history

  2. fix HybridBayesTree::optimize to account for pruned nodes

    @varunagrawal
    varunagrawal committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    7ae4e57 View commit details
    Browse the repository at this point in the history

  3. fix creation of updatedBayesTree

    @varunagrawal
    varunagrawal committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    d54cf48 View commit details
    Browse the repository at this point in the history

  4. fixup the final tests

    @varunagrawal
    varunagrawal committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    318f738 View commit details
    Browse the repository at this point in the history

  5. update docstring for Ordering::+=

    @varunagrawal
    varunagrawal committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    6e6bbff View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2022

  1. make continuousProbPrimes and continuousDeltas as templates

    @varunagrawal
    varunagrawal committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    5e2cdfd View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. address review comments

    @varunagrawal
    varunagrawal committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    2394129 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. better printing

    @varunagrawal
    varunagrawal committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    05b2d31 View commit details
    Browse the repository at this point in the history

  2. move multifrontal optimize test to testHybridBayesTree and update doc… 

    …strings
    @varunagrawal
    varunagrawal committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    3eaf4cc View commit details
    Browse the repository at this point in the history

  3. moved sequential elimination code to HybridEliminationTree

    @varunagrawal
    varunagrawal committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    cd3cfa0 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2022

  1. add getters to HybridEliminationTree

    @varunagrawal
    varunagrawal committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    15fffeb View commit details
    Browse the repository at this point in the history

  2. override eliminate in HybridJunctionTree

    @varunagrawal
    varunagrawal committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    addbe2a View commit details
    Browse the repository at this point in the history

  3. split up the eliminate method to constituent parts

    @varunagrawal
    varunagrawal committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    ae0b3e3 View commit details
    Browse the repository at this point in the history

  4. mark helper methods as protected and add docstrings

    @varunagrawal
    varunagrawal committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    bed56e0 View commit details
    Browse the repository at this point in the history

  5. more unit tests

    @varunagrawal
    varunagrawal committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    5fc114f View commit details
    Browse the repository at this point in the history

  6. Add details about the role of the HybridEliminationTree in hybrid eli… 

    …mination
    @varunagrawal
    varunagrawal committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    22e4a73 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. remove unrequired code

    @varunagrawal
    varunagrawal committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    0596b2f View commit details
    Browse the repository at this point in the history

  2. update hybrid elimination and corresponding tests

    @varunagrawal
    varunagrawal committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    62bc9f2 View commit details
    Browse the repository at this point in the history

  3. remove commented out code

    @varunagrawal
    varunagrawal committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    6beffeb View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1339 from borglab/hybrid/new-elimination

    @varunagrawal
    varunagrawal authored Dec 10, 2022
    Configuration menu
    Copy the full SHA
    da5d3a2 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. minor cleanup

    @varunagrawal
    varunagrawal committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    812bf52 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'hybrid/error' into hybrid/tests

    @varunagrawal
    varunagrawal committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    6b6731a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'hybrid/tests' into hybrid/multifrontal

    @varunagrawal
    varunagrawal committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    46380ca View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. Merge pull request #1323 from borglab/hybrid/multifrontal

    @varunagrawal
    varunagrawal authored Dec 23, 2022
    Configuration menu
    Copy the full SHA
    583d121 View commit details
    Browse the repository at this point in the history

  2. add optional model parameter to sample method

    @varunagrawal
    varunagrawal committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    ffd1802 View commit details
    Browse the repository at this point in the history

  3. sampling test

    @varunagrawal
    varunagrawal committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    bdb7836 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2022

  1. Merge branch 'develop' into hybrid/tests

    @varunagrawal
    varunagrawal committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    ae0df47 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into hybrid/tests

    @varunagrawal
    varunagrawal committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    153c12e View commit details
    Browse the repository at this point in the history

  3. Revert "add optional model parameter to sample method" 

    This reverts commit ffd1802.
    @varunagrawal
    varunagrawal committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    aa86af2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'hybrid/tests' into hybrid/verification

    @varunagrawal
    varunagrawal committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    6b834db View commit details
    Browse the repository at this point in the history

  5. update sampling test to use new sample method

    @varunagrawal
    varunagrawal committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    798c51a View commit details
    Browse the repository at this point in the history

  6. address review comments

    @varunagrawal
    varunagrawal committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    13d22b1 View commit details
    Browse the repository at this point in the history

  7. compute sampling ratio for one sample and then for multiple samples

    @varunagrawal
    varunagrawal committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    1e17dd3 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2022

  1. Merge pull request #1346 from borglab/hybrid/verification 

    Sampling test for Hybrid Posterior
    @varunagrawal
    varunagrawal authored Dec 25, 2022
    Configuration menu
    Copy the full SHA
    f3c85ae View commit details
    Browse the repository at this point in the history

  2. Implement printing rather than calling factor graph version

    @dellaert
    dellaert committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    76e838b View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2022

  1. Small comments

    @dellaert
    dellaert committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    4ad482a View commit details
    Browse the repository at this point in the history

  2. Refactor elimination setup to not use C declaration style

    @dellaert
    dellaert committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    a7573e8 View commit details
    Browse the repository at this point in the history

  3. Separated out NFG setup and added test.

    @dellaert
    dellaert committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    8a319c5 View commit details
    Browse the repository at this point in the history

  4. Fix print test

    @dellaert
    dellaert committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    db17a04 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2022

  1. Merge pull request #1349 from borglab/hybrid/two_ways

    @varunagrawal
    varunagrawal authored Dec 27, 2022
    Configuration menu
    Copy the full SHA
    cfcbdda View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2022

  1. Merge branch 'develop' into hybrid/tests

    @varunagrawal
    varunagrawal committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    cf46c36 View commit details
    Browse the repository at this point in the history

  2. minor fixes

    @varunagrawal
    varunagrawal committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    28f349c View commit details
    Browse the repository at this point in the history