Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hybrid Elimination #1339

Merged
merged 12 commits into from
Dec 10, 2022
Merged

Hybrid Elimination #1339

merged 12 commits into from
Dec 10, 2022

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Dec 4, 2022 •
edited
Loading

This PR moves the logic for hybrid elimination to the EliminationTree/JunctionTree.

Now we no longer have to override any eliminate methods in the HybridGaussianFactorGraph class.

Updated elimination to be "stateless" so it follows the general algorithm for elimination.

@varunagrawal varunagrawal self-assigned this Dec 4, 2022
@varunagrawal varunagrawal changed the title Hybrid Elimination/Junction Tree Hybrid Elimination Dec 10, 2022
@varunagrawal varunagrawal merged commit da5d3a2 into hybrid/multifrontal Dec 10, 2022
@varunagrawal varunagrawal deleted the hybrid/new-elimination branch December 10, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert Awaiting requested review from dellaert

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@varunagrawal