Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/4.2a4 #1073

Merged
merged 109 commits into from
Jan 28, 2022
Merged

Release/4.2a4 #1073

merged 109 commits into from
Jan 28, 2022

Conversation

dellaert
Copy link
Member

No description provided.

dellaert and others added 30 commits December 30, 2021 12:12
@dellaert
Removed shared_ptr from Bayes nets and factor graphs
c659336
@dellaert
Fix compilation issues
910f879
@dellaert
Fix wrap of subgraph
fceb65a
added robustness to triangulation
3ef6974
moved invDepth-related variables
c407609
@johnwlambert
Update test_Triangulation.py
b60ca0c
@johnwlambert
fix syntax errors
d66b1d7
@johnwlambert
add missing type hint
f009a14
@johnwlambert
yapf pep8 reformat
e2993ea
@johnwlambert
wrap new noise model arg for gtsam.triangulatePoint3
1614ce0
@johnwlambert
add missing type hint import
0f1ff48
@johnwlambert
add missing type hint annotation import
0ff9110
@johnwlambert
Merge pull request #1031 from borglab/add-python-unit-test-robust-noise
aef2a39 
Add python unit test for triangulation with robust noise model
@magicbycalvin
Added a convenience function for plotting 2D points.
2e8dcdd
@dellaert
Merge pull request #1037 from borglab/feature/discrete_operators
f3d9486
@dellaert
Merge pull request #1039 from borglab/feature/DiscreteDistribution
950ab11
@dellaert
Merge pull request #1040 from borglab/release/4.2a3
f1ab445
@dellaert
Merge pull request #1020 from borglab/feature/robustTriangulation
a74da73
@dellaert
sample variants
10e1bd2
@dellaert
Merge pull request #1043 from borglab/feature/more_discrete_methods
296b469
@magicbycalvin
Removed a spurious commented line and included a comment about what t…
2430917 
…he K value signifies.
@dellaert
Some reformatting/docs/using
7557bd9
@dellaert
Wrap push_back methods
1702c20
@dellaert
Change default to not confuse people
2413fcb
@dellaert
New, more powerful choose, yields a Conditional now
4a10ea8
@dellaert
Fix unit tests after default changed
75dff32
@varunagrawal
Merge pull request #1042 from magicbycalvin/develop
ee7d32d 
Added a convenience function for plotting 2D points.
@dellaert
Add formatter
e9d7843
@dellaert
Wrap partial eliminate
a1f5ae0
@dellaert
Use key formatter for dot
640a3b8
johnwlambert
johnwlambert approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@johnwlambert johnwlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why are we using master instead of develop though?

@dellaert
Copy link
Member Author

Thanks John. There are two PRs, one into master and one into develop. Please approve both :-)
See https://gtsam.org/notes/Contributing.html

@johnwlambert
Copy link
Contributor

Thanks John. There are two PRs, one into master and one into develop. Please approve both :-) See https://gtsam.org/notes/Contributing.html

Got it, both are approved : - )

@dellaert dellaert merged commit d6edcea into master Jan 28, 2022
@dellaert dellaert deleted the release/4.2a4 branch January 28, 2022 20:40
@ProfFan ProfFan restored the release/4.2a4 branch January 28, 2022 21:18
@ProfFan
Copy link
Collaborator

ProfFan commented Jan 28, 2022

Release branches should be kept as is @dellaert

@dellaert
Copy link
Member Author

I don't think so... Maybe discuss with me first?

@dellaert
Copy link
Member Author

Gitflow convention is to tag and delete the branch, AFAIK.
But I see that we need it for manylinux build :-) That's a different issue, and glad you restored it.

@varunagrawal varunagrawal deleted the release/4.2a4 branch January 31, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnwlambert johnwlambert johnwlambert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dellaert @johnwlambert @ProfFan @magicbycalvin @varunagrawal @senselessDev