Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinhole camera factor for localization only #697

Closed
jlblancoc opened this issue Feb 13, 2021 · 2 comments · Fixed by #696
Closed

Pinhole camera factor for localization only #697

jlblancoc opened this issue Feb 13, 2021 · 2 comments · Fixed by #696
Labels
enhancement Improvement to GTSAM feature New proposed feature

Comments

@jlblancoc
Copy link
Member

Feature

Having a factor where the pose of the camera is the only variable, with fixed landmarks and calibration.

Motivation

Vision-based localization / tracking / etc.

Additional context

I have already written such a factor by modifying the existing GenericProjectionFactor... would it be useful to integrate it into GTSAM? If yes: any preference on its name?

@jlblancoc jlblancoc added enhancement Improvement to GTSAM feature New proposed feature labels Feb 13, 2021
@dellaert
Copy link
Member

There is also one in unstable, and @lucacarlone is creating another one. We could probably benefit from coordinating :-)

@jlblancoc
Copy link
Member Author

👍

In gtsam_unstable, I found ProjectionFactorPPP and ProjectionFactorPPPC, which estimate more variables (body-camera pose), but landmarks are still an unknown too. I'll let Luca to decide whether his proposal in #696 makes this one #697 unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to GTSAM feature New proposed feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants