Skip to content

refactor: standardize quick-flow menu patterns to newer format#1388

Merged
bmadcode merged 2 commits intobmad-code-org:mainfrom
alexeyv:refactor/quick-flow-menu-standards
Jan 24, 2026
Merged

refactor: standardize quick-flow menu patterns to newer format#1388
bmadcode merged 2 commits intobmad-code-org:mainfrom
alexeyv:refactor/quick-flow-menu-standards

Conversation

@alexeyv
Copy link
Copy Markdown
Collaborator

@alexeyv alexeyv commented Jan 24, 2026

Summary

  • Uppercase all menu option letters ([A], [P], [C], [T], [E], [W], etc.)
  • Add "Menu Handling Logic:" sections with IF/THEN structure
  • Add "EXECUTION RULES:" sections with halt/wait behavior
  • Add chat handling for checkpoint menus (A/P/C)
  • Remove code blocks from Display patterns, use standard format
  • Add header for adversarial review process block

Test plan

  • Verify no lowercase menu options remain in quick-flow: grep -r "\[a\]" src/bmm/workflows/bmad-quick-flow/
  • Verify Menu Handling Logic sections exist: grep -r "Menu Handling Logic:" src/bmm/workflows/bmad-quick-flow/
  • Verify EXECUTION RULES sections exist: grep -r "EXECUTION RULES:" src/bmm/workflows/bmad-quick-flow/
  • Run quick-spec workflow and confirm menus display correctly
  • Run quick-dev workflow and confirm escalation menus work

🤖 Generated with Claude Code

@alexeyv alexeyv force-pushed the refactor/quick-flow-menu-standards branch from 5cd92a7 to 6fe5fe2 Compare January 24, 2026 08:32
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 24, 2026

📝 Walkthrough

Walkthrough

This PR formalizes interactive menus across quick-dev and quick-spec workflow steps by replacing freeform prompts with explicit IF/THEN menu handling, adding EXECUTION RULES that require halting for user input, standardizing option capitalization, and changing NEXT directives to "Read fully and follow" in several steps.

Changes

Cohort / File(s) Summary
Mode Detection & Resolve Findings (quick-dev)
src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-01-mode-detection.md, src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-06-resolve-findings.md
Replaced textual menus with IF/THEN branches and EXECUTION RULES; updated menu handling logic and NEXT directives to require halting and explicit selection before proceeding.
Context / Execute / Adversarial (quick-dev)
src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-02-context-gathering.md, src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-03-execute.md, src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-05-adversarial-review.md
Changed NEXT-step phrasing from "load" to "Read fully and follow:" to make progression explicit; minor wording updates to READY/NEXT directives.
Understand (quick-spec step 01)
src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-01-understand.md
Uppercased option labels, expanded menu into Menu Handling Logic with IF branches for A/P/C, added acceptance prompts, WIP file handling, and EXECUTION RULES enforcing halt-and-wait and return-to-menu semantics.
Investigate (quick-spec step 02)
src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-02-investigate.md
Consolidated display prompt; replaced Menu Handling with explicit IF-THEN logic for A/P/C, added acceptance flow and EXECUTION RULES requiring halts and controlled advancement.
Review (quick-spec step 04)
src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.md
Replaced static review menu with consolidated Display and Menu Handling Logic; added IF branches for Y/C/Q/A/P and new Adversarial Review [R] pipeline, plus EXECUTION RULES and standardized capitalization.
Workflow Master (quick-spec workflow.md)
src/bmm/workflows/bmad-quick-flow/quick-spec/workflow.md
Adjusted step processing rule from [c] to [C] for continuation input.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~30 minutes

Possibly related PRs

Suggested reviewers

  • bmadcode
  • muratkeremozcan
  • pbean
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: standardizing quick-flow menu patterns to a newer format with uppercase options, Menu Handling Logic sections, and EXECUTION RULES.
Description check ✅ Passed The description clearly relates to the changeset, detailing the key refactoring goals (uppercase menu options, new sections, display format changes) and providing a test plan with specific verification commands.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alexeyv alexeyv force-pushed the refactor/quick-flow-menu-standards branch from 6fe5fe2 to dfe3121 Compare January 24, 2026 08:38
Update quick-spec and quick-dev workflow menus to match established standards:
- Uppercase all menu option letters ([A], [P], [C], [T], [E], [W], etc.)
- Add "Menu Handling Logic:" sections with IF/THEN structure
- Add "EXECUTION RULES:" sections with halt/wait behavior
- Add chat handling for checkpoint menus (A/P/C)
- Remove code blocks from Display patterns, use standard format
- Add header for adversarial review process block

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@alexeyv alexeyv force-pushed the refactor/quick-flow-menu-standards branch from dfe3121 to 4918713 Compare January 24, 2026 08:40
@alexeyv
Copy link
Copy Markdown
Collaborator Author

alexeyv commented Jan 24, 2026

@CodeRabbit review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 24, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@bmadcode bmadcode merged commit 8bdf21f into bmad-code-org:main Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants