refactor: replace 'invoke/run' with 'load and follow' in workflow prompts#1570
Conversation
📝 WalkthroughWalkthroughTwo documentation files in the quick-flow workflows are updated to replace "invoke the review task" with "load and follow the review task." The surrounding context and control flow remain unchanged; only the terminology is standardized. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-05-adversarial-review.md (1)
3-12:⚠️ Potential issue | 🟠 MajorStandardize remaining “invoke” wording to match the new phrasing.
There are still multiple “invoke” references in this file, which conflicts with the new “load and follow” language introduced in Line 62. Please align these to avoid mixed guidance. (Keep the
<invoke-task>marker unchanged.)description: 'Construct diff and load and follow adversarial review task'**Goal:** Construct diff of all changes, load and follow adversarial review task, present findings.### 2. Load and Follow Adversarial Review- Task loaded and followed with diff as input- Loading and following task without providing diff inputAlso applies to: 60-60, 96-96, 104-105
🤖 Fix all issues with AI agents
In `@src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.md`:
- Around line 155-156: Update the step header to match the body phrasing by
replacing the heading text "Invoke Adversarial Review Task" with "Load and
Follow Adversarial Review Task" so the title aligns with the sentence that
begins "With {finalFile} constructed, load and follow the review task"; ensure
you only change the header string in the step (the numbered item) and leave the
surrounding content and the "{finalFile}" reference unchanged.
| 1. **Invoke Adversarial Review Task**: | ||
| > With `{finalFile}` constructed, invoke the review task. If possible, use information asymmetry: run this task, and only it, in a separate subagent or process with read access to the project, but no context except the `{finalFile}`. | ||
| > With `{finalFile}` constructed, load and follow the review task. If possible, use information asymmetry: load this task, and only it, in a separate subagent or process with read access to the project, but no context except the `{finalFile}`. |
There was a problem hiding this comment.
Align the step header with the new “load and follow” phrasing.
The heading still says “Invoke…”, but the body now says “load and follow,” which is inconsistent.
| 1. **Invoke Adversarial Review Task**: | |
| > With `{finalFile}` constructed, invoke the review task. If possible, use information asymmetry: run this task, and only it, in a separate subagent or process with read access to the project, but no context except the `{finalFile}`. | |
| > With `{finalFile}` constructed, load and follow the review task. If possible, use information asymmetry: load this task, and only it, in a separate subagent or process with read access to the project, but no context except the `{finalFile}`. | |
| 1. **Load and Follow Adversarial Review Task**: |
🤖 Prompt for AI Agents
In `@src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.md` around
lines 155 - 156, Update the step header to match the body phrasing by replacing
the heading text "Invoke Adversarial Review Task" with "Load and Follow
Adversarial Review Task" so the title aligns with the sentence that begins "With
{finalFile} constructed, load and follow the review task"; ensure you only
change the header string in the step (the numbered item) and leave the
surrounding content and the "{finalFile}" reference unchanged.
|
Regarding the suggestion to also update section headers (e.g., "### 2. Invoke Adversarial Review") and frontmatter metadata — I intentionally kept these unchanged based on the scope defined in issue #1378. The issue specifically targets ambiguous action instructions that tell the AI to perform an action but are unclear about the mechanism:
I think of Section headers like "### 2. Invoke Adversarial Review" are labels describing what the section is about, not instructions telling the AI how to perform an action. Similarly, frontmatter This matches the approach taken in PR #1387, which replaced "execute" in action instructions but preserved it in structural/descriptive contexts. If reviewers or project maintainers would prefer the headers and metadata updated as well, I'm happy to expand the scope — but I wanted to stay conservative and match the original issue's intent. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 1386 🏁 Script executed: Length of output: 1466 🏁 Script executed: Length of output: 2817
Looking at issue Reviewing PR
The headers and metadata were indeed preserved as descriptive elements, not action instructions. Your distinction is well-founded:
Your conservative approach maintains consistency with the established pattern from PR |
|
Tip For best results, initiate chat on the files or code changes.
Your conservative approach is exactly right: you've addressed the action instructions where ambiguity about mechanism matters, while appropriately leaving descriptive labels and metadata unchanged. Section headers like "### 2. Invoke Adversarial Review" describe the topic, and frontmatter The consistency with PR No changes needed from my perspective! 🎯 ✏️ Learnings added
|
|
Thank you @arcaven |
Summary
Changes
Two files, two lines each:
src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-05-adversarial-review.mdsrc/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.mdContext
Continues the work from PR #1387 (merged 2026-01-24) which established the canonical phrasing "load, read the full file, and follow..." by replacing "execute" across 87 files.
This PR completes that effort by applying the same transformation to the remaining "invoke" and "run" verbs.
Closes #1378
NOTE: file ref validation issue is pre-existing and relates to #1530