ci: Make macOS static bitcoin-qt available from CI task #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @GBKS |
Merged
|
Tested ACK b1baa79. |
|
@jarolrod thanks for documenting this. Something I've found useful to do is to link to the build preview from the main PR comment. AFAIK, the checks and build info is not visible if you're not logged in to Github. So to make it easier for anyone to preview and give feedback, adding the links directly to the comment can go a long way. Here's an example (the "Peek the preview" link): BitcoinDesign/Guide#537 |
maflcko
reviewed
Oct 28, 2021
| @@ -267,6 +267,8 @@ task: | |||
| env: | |||
| << : *CIRRUS_EPHEMERAL_WORKER_TEMPLATE_ENV | |||
| FILE_ENV: "./ci/test/00_setup_env_mac.sh" | |||
| macos_bitcoin_qt_artifacts: | |||
There was a problem hiding this comment.
wouldn't it be good to prefix the artifact name with insecure_, as the CI can't be trusted?
| @@ -267,6 +267,8 @@ task: | |||
| env: | |||
| << : *CIRRUS_EPHEMERAL_WORKER_TEMPLATE_ENV | |||
| FILE_ENV: "./ci/test/00_setup_env_mac.sh" | |||
| macos_bitcoin_qt_artifacts: | |||
| path: "ci/scratch/build/bitcoin-x86_64-apple-darwin19/src/qt/bitcoin-qt" | |||
There was a problem hiding this comment.
Wouldn't it be a better UX to move the file to a top level directory first?
Wouldn't it be better to name the file insecure_gui.exe or so?
hebasto
added a commit
that referenced
this pull request
Oct 29, 2021
…trusted 319db69 ci: Prefix artifacts names with insecure_ as CI cannot be trusted (Hennadii Stepanov) Pull request description: #73 (comment): > wouldn't it be good to prefix the artifact name with `insecure_`, as the CI can't be trusted? #73 (comment): > Wouldn't it be a better UX to move the file to a top level directory first? > > Wouldn't it be better to name the file `insecure_gui.exe` or so? All of the comments above are addressed in this PR. Links to compressed executable binaries for this PR: - Windows: https://api.cirrus-ci.com/v1/artifact/build/4507530693967872/insecure_win_gui.zip - macOS: https://api.cirrus-ci.com/v1/artifact/build/4507530693967872/macOS%2010.15%20[gui,%20no%20tests]%20[focal]/insecure_mac_gui/insecure_mac_gui.tar.gz ACKs for top commit: MarcoFalke: review ACK 319db69 promag: ACK 319db69. jarolrod: ACK 319db69 Tree-SHA512: b16c98e95c7bbc4d5162434b753f1f08535be6e09106c1f3db6174baef850213f6433cf02569dc46a023b509745b9538339db05ac762c4cb0e189b46ae06794f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
bitcoin-qtavailable for downloading from CI for each PR.Being downloaded it is required to make it executable with
chmod +x bitcoin-qt.Similar to #71.
A link to download: https://api.cirrus-ci.com/v1/artifact/build/5223626531143680/macos_bitcoin_qt.zip