Skip to content

Added ⚡️ content to Onboarding > Protecting a wallet #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 2, 2021

Conversation

GBKS
Copy link
Contributor

@GBKS GBKS commented Oct 22, 2021

See #517 for a discussion of the changes.

Keeping this in draft mode for now as I am still working on things.

⚔️ Peek the preview 🛡

  • Add security and privacy checklist concept
  • Add info about pro-actively supporting users
  • Add wallet limit concept
  • Revise existing images for consistency
  • See if adding option to delete the recovery phrase makes sense
  • See if adding option for a dummy PIN to show fake data makes sense
  • Clarify scope of the page in the intro
  • Look for cross-linking opportunities
  • Overall copy review

Review notes
The page has gotten quite long, as 11 different techniques are described. The new categories help a bit, but I am still wondering if we shouldn't condense a bit further.

Added new paragraphs about
- Security & privacy checklist
- Progressive security
- Wallet limits

Also revised images, layout and captions overall for consistency.

Next step will be to revise overall copy.
@GBKS GBKS added Copy Task is about improving text. Design Task is about designing something. Onboarding labels Oct 22, 2021
@GBKS GBKS added this to the Milestone #9 milestone Oct 22, 2021
@GBKS GBKS self-assigned this Oct 22, 2021
@GBKS GBKS linked an issue Oct 22, 2021 that may be closed by this pull request
Rogelio165
Rogelio165 previously approved these changes Oct 24, 2021
- Images for feature details, fake wallet PIN choice, and deleting a recovery phrase
- Restructured the page into clearer sections, with a table of contents at the top
- Copy review for consistency and clarity
@GBKS GBKS marked this pull request as ready for review October 25, 2021 12:53
Copy link
Collaborator

@Bosch-0 Bosch-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @GBKS! Looking good, left a few comments but nothing major.

Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Bosch-0
Bosch-0 previously approved these changes Oct 27, 2021
@Bosch-0
Copy link
Collaborator

Bosch-0 commented Oct 27, 2021

Something we haven't discussed in this section, which I think is relevant, is networking privacy.

We should be recommending all wallets have a connect over Tor option or just have Tor by default. It becomes very important when you introduce LSPs into the mix.

Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
GBKS added a commit that referenced this pull request Oct 28, 2021
In #537, more Settings screens were added that have a very faint background grey color. This results in super low contrast where the screens almost blends with the background. This tweak makes the gallery background very slightly darker and the box-shadow slightly stronger for better contrast.
Copy link
Collaborator

@sbddesign sbddesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Good content!

I left you some nit-picky grammar fixes. Many are based on rules of grammar, but some are just my opinion regarding writing style.

GBKS and others added 5 commits October 29, 2021 08:53
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Bosch-0
Bosch-0 previously approved these changes Nov 2, 2021
Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, LGTM. 🚀

@netlify
Copy link

netlify bot commented Nov 8, 2021

A new user left a comment. This user must be approved by a Netlify team owner before comments can be displayed.

Approve this user

@danielnordh danielnordh deleted the feature/protecting-a-wallet-revision branch December 2, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Copy Task is about improving text. Design Task is about designing something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ⚡️ content to Onboarding > Protecting a wallet
6 participants