-
Notifications
You must be signed in to change notification settings - Fork 110
Added ⚡️ content to Onboarding
> Protecting a wallet
#537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added new paragraphs about - Security & privacy checklist - Progressive security - Wallet limits Also revised images, layout and captions overall for consistency. Next step will be to revise overall copy.
- Images for feature details, fake wallet PIN choice, and deleting a recovery phrase - Restructured the page into clearer sections, with a table of contents at the top - Copy review for consistency and clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @GBKS! Looking good, left a few comments but nothing major.
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Something we haven't discussed in this section, which I think is relevant, is networking privacy. We should be recommending all wallets have a connect over Tor option or just have Tor by default. It becomes very important when you introduce LSPs into the mix. |
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
….com/BitcoinDesign/Guide into feature/protecting-a-wallet-revision
In #537, more Settings screens were added that have a very faint background grey color. This results in super low contrast where the screens almost blends with the background. This tweak makes the gallery background very slightly darker and the box-shadow slightly stronger for better contrast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Good content!
I left you some nit-picky grammar fixes. Many are based on rules of grammar, but some are just my opinion regarding writing style.
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Daniel Nordh <3393669+danielnordh@users.noreply.github.com> Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, LGTM. 🚀
A new user left a comment. This user must be approved by a Netlify team owner before comments can be displayed. |
See #517 for a discussion of the changes.
Keeping this in draft mode for now as I am still working on things.
⚔️ Peek the preview 🛡
Review notes
The page has gotten quite long, as 11 different techniques are described. The new categories help a bit, but I am still wondering if we shouldn't condense a bit further.