ci: Make Win64 static bitcoin-qt.exe available from CI task #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it what you have been expected for? |
|
ACK, very nice! I was able to download and run the artifact. |
|
ACK. That is fantastic. |
|
ACK d228a5c. For how long are the artifacts available? |
It is not clear documented 🤷♂️ |
|
ACK from me on windows, looks great! This will speed up testing from designers a lot :) |
hebasto
added a commit
that referenced
this pull request
Oct 28, 2021
b1baa79 ci: Add artifacts instruction to macOS task (Hennadii Stepanov) Pull request description: This PR makes `bitcoin-qt` available for downloading from CI for each PR. Being downloaded it is required to make it executable with `chmod +x bitcoin-qt`. Similar to #71. A link to download: https://api.cirrus-ci.com/v1/artifact/build/5223626531143680/macos_bitcoin_qt.zip ACKs for top commit: promag: Tested ACK b1baa79. jarolrod: ACK b1baa79 Tree-SHA512: eb339ca7fae0686fda924365f5ce03f282eeb55b50dc35936b75fdaba89e4ad2e85eb7c6ee166985de548c5246dadf1b8f76039b518a7d833609fe11e0b1286d
maflcko
reviewed
Oct 28, 2021
| @@ -173,6 +173,8 @@ task: | |||
| env: | |||
| << : *CIRRUS_EPHEMERAL_WORKER_TEMPLATE_ENV | |||
| FILE_ENV: "./ci/test/00_setup_env_win64.sh" | |||
| bitcoin_qt_artifacts: | |||
| path: "ci/scratch/build/bitcoin-x86_64-w64-mingw32/release/bitcoin-qt.exe" | |||
There was a problem hiding this comment.
Same feedback here as #73.
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 6, 2025
Github-Pull: bitcoin-core#71 Rebased-From: 500a6d2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
Github-Pull: bitcoin-core#71 Rebased-From: 500a6d2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
Github-Pull: bitcoin-core#71 Rebased-From: 500a6d2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#71 Rebased-From: 500a6d2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#71 Rebased-From: 500a6d2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#71 Rebased-From: 500a6d2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#71 Rebased-From: 500a6d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
bitcoin-qt.exeavailable for downloading from CI for each PR.This should make testing PRs by designers a bit easier.
If this idea will work for Windows, the similar approach can be expected for macOS binaries.
A link to download: https://api.cirrus-ci.com/v1/artifact/build/4640743399620608/bitcoin_qt.zip
To get the unique
4640743399620608identifier, one can follow the links as depicted on screenshots: