passport-saml upgade

[ukch]

Closes biblemesh/ereader-development#108

@Fydon it seems like a simple switch but please double-check there are not going to be any gotchas here.

[Fydon]

Thank you. Does the login still complete successfully? Could you please provide the output of https://data.stg.read.test/Shibboleth.sso/Metadata?

[ukch]

@Fydon unfortunately not.

reader-1             | TypeError: idpCert is required
reader-1             |     at assertRequired (/app/node_modules/@node-saml/node-saml/lib/utility.js:10:15)
reader-1             |     at SAML.initialize (/app/node_modules/@node-saml/node-saml/lib/saml.js:53:38)
reader-1             |     at new SAML (/app/node_modules/@node-saml/node-saml/lib/saml.js:43:29)
reader-1             |     at new AbstractStrategy (/app/node_modules/@node-saml/passport-saml/lib/strategy.js:28:26)
reader-1             |     at new Strategy (/app/node_modules/@node-saml/passport-saml/lib/strategy.js:215:1)
reader-1             |     at /app/app.js:384:28
reader-1             |     at Array.forEach (<anonymous>)
reader-1             |     at /app/app.js:382:10
reader-1             |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
reader-1             | Jan 22, 2026, 01:25:23 UTC ERR  Unhandled node error TypeError: idpCert is required
reader-1             |     at assertRequired (/app/node_modules/@node-saml/node-saml/lib/utility.js:10:15)
reader-1             |     at SAML.initialize (/app/node_modules/@node-saml/node-saml/lib/saml.js:53:38)
reader-1             |     at new SAML (/app/node_modules/@node-saml/node-saml/lib/saml.js:43:29)
reader-1             |     at new AbstractStrategy (/app/node_modules/@node-saml/passport-saml/lib/strategy.js:28:26)
reader-1             |     at new Strategy (/app/node_modules/@node-saml/passport-saml/lib/strategy.js:215:1)
reader-1             |     at /app/app.js:384:28
reader-1             |     at Array.forEach (<anonymous>)
reader-1             |     at /app/app.js:382:10
reader-1             |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

I guess the 'cert' argument to saml.Strategy should be renamed to 'idpCert'. Anywhere else you can see the API could have changed in a way that would affect us?

[ukch]

@Fydon please rereview (depends #59)

[Fydon]

Sorry as I had to redo the work, I didn't update passport in this attempt. Please update passport to "0.5.3" as fixed version, as newer versions require more work to correct session handling

[ukch]

@alitokgonul it looks like the new tests you wrote are failing here and it's not immediately obvious why. Can you please investigate this?

[alitokgonul]

@alitokgonul it looks like the new tests you wrote are failing here and it's not immediately obvious why. Can you please investigate this?

@joel Cross I have checked this but I couldn't find any reasons why test fails on CI. because locally, all tests pass in bm-develop and your branch

[Fydon]

Having a quick look, it might be because of the new dependency @types/express

@alitokgonul Did you run npm ci before running the test?