Skip to content

Fix/reader hanging#59

Merged
ukch merged 5 commits intobm-developfrom
fix/reader-hanging
Feb 6, 2026
Merged

Fix/reader hanging#59
ukch merged 5 commits intobm-developfrom
fix/reader-hanging

Conversation

@ukch
Copy link

@ukch ukch commented Jan 30, 2026

Fix error introduced in #41

Closes biblemesh/ereader-development#111

@ukch ukch requested review from Fydon and alitokgonul January 30, 2026 03:54
@ukch ukch mentioned this pull request Jan 30, 2026
Copy link

@Fydon Fydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Having a quick look, I think I see 14 changes to have the catch return in #41 but only 12 are being reverted here. Please ensure that there are no more that should be reverted

@ukch
Copy link
Author

ukch commented Feb 4, 2026

Thank you. Having a quick look, I think I see 14 changes to have the catch return in #41 but only 12 are being reverted here. Please ensure that there are no more that should be reverted

OK, I did check the other PR and thought I caught them all. Let me double check.

@ukch ukch requested a review from Fydon February 5, 2026 21:11
@ukch
Copy link
Author

ukch commented Feb 5, 2026

@Fydon you were right, there were 2 I missed! Please rereview.

@ukch ukch merged commit f27b712 into bm-develop Feb 6, 2026
6 checks passed
@ukch ukch deleted the fix/reader-hanging branch February 6, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants