Use @node-saml/passport-saml instead#54
Merged
ukch merged 2 commits intofix/passport-samlfrom Jan 30, 2026
Merged
Conversation
Fydon
force-pushed
the
fix/passport-saml-2
branch
from
9c0678d to
948d705
Compare
ukch
approved these changes
Jan 27, 2026
ukch
left a comment
ukch
left a comment
There was a problem hiding this comment.
This looks good to me. Let's figure out the exact issue with the build and then rebase this into the other PR.
ukch
force-pushed
the
fix/passport-saml-2
branch
from
948d705 to
8d74a79
Compare
ukch
force-pushed
the
fix/passport-saml-2
branch
from
8d74a79 to
20d2873
Compare
ukch
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on the work of #51, but rebased on eb83311 as newer commits result in no response from express. When
bm-developis working again, this can be rebase ontofix/passport-samlto remove the altered commits from that branch.