add perf comment

mockersf · mockersf · commit e57781a749a1 · 2021-12-23T22:38:50.000+01:00
diff --git a/crates/bevy_transform/src/hierarchy/hierarchy_maintenance_system.rs b/crates/bevy_transform/src/hierarchy/hierarchy_maintenance_system.rs
@@ -49,6 +49,7 @@ pub fn parent_update_system(
         // `children_additions`).
         if let Ok(mut new_parent_children) = children_query.get_mut(parent.0) {
             // This is the parent
+            // PERF: Ideally we shouldn't need to check for duplicates
             if !(*new_parent_children).0.contains(&entity) {
                 (*new_parent_children).0.push(entity);
             }

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ pub fn parent_update_system(`
`49`	`49`	// `children_additions`).
`50`	`50`	`if let Ok(mut new_parent_children) = children_query.get_mut(parent.0) {`
`51`	`51`	`// This is the parent`
	`52`	`+ // PERF: Ideally we shouldn't need to check for duplicates`
`52`	`53`	`if !(*new_parent_children).0.contains(&entity) {`
`53`	`54`	`(*new_parent_children).0.push(entity);`
`54`	`55`	`}`