Remove ModifiesWindows

Author: tim-blackbird

crates/bevy_pbr/src/lib.rs

@@ -11,7 +11,6 @@ mod render;
 
 pub use alpha::*;
 use bevy_transform::TransformSystem;
-use bevy_window::ModifiesWindows;
 pub use bundle::*;
 pub use fog::*;
 pub use light::*;
@@ -199,8 +198,7 @@ impl Plugin for PbrPlugin {
                     .in_set(SimulationLightSystems::AssignLightsToClusters)
                     .after(TransformSystem::TransformPropagate)
                     .after(VisibilitySystems::CheckVisibility)
-                    .after(CameraUpdateSystem)
-                    .after(ModifiesWindows),
+                    .after(CameraUpdateSystem),
             )
             .add_system(
                 update_directional_light_cascades

crates/bevy_render/src/camera/projection.rs

@@ -7,7 +7,6 @@ use bevy_reflect::{
     std_traits::ReflectDefault, FromReflect, GetTypeRegistration, Reflect, ReflectDeserialize,
     ReflectSerialize,
 };
-use bevy_window::ModifiesWindows;
 use serde::{Deserialize, Serialize};
 
 /// Adds [`Camera`](crate::camera::Camera) driver systems for a given projection type.
@@ -43,7 +42,6 @@ impl<T: CameraProjection + Component + GetTypeRegistration> Plugin for CameraPro
             .add_system(
                 crate::camera::camera_system::<T>
                     .in_set(CameraUpdateSystem)
-                    .after(ModifiesWindows)
                     // We assume that each camera will only have one projection,
                     // so we can ignore ambiguities with all other monomorphizations.
                     // FIXME: Add an archetype invariant for this https://github.com/bevyengine/bevy/issues/1481.

crates/bevy_text/src/lib.rs

@@ -28,7 +28,6 @@ use bevy_asset::AddAsset;
 use bevy_ecs::prelude::*;
 use bevy_render::{camera::CameraUpdateSystem, ExtractSchedule, RenderApp};
 use bevy_sprite::SpriteSystem;
-use bevy_window::ModifiesWindows;
 use std::num::NonZeroUsize;
 
 #[derive(Default)]
@@ -83,7 +82,6 @@ impl Plugin for TextPlugin {
             .add_system(
                 update_text2d_layout
                     .in_base_set(CoreSet::PostUpdate)
-                    .after(ModifiesWindows)
                     // Potential conflict: `Assets<Image>`
                     // In practice, they run independently since `bevy_render::camera_update_system`
                     // will only ever observe its own render target, and `update_text2d_layout`

crates/bevy_ui/src/lib.rs

@@ -34,7 +34,6 @@ use bevy_app::prelude::*;
 use bevy_ecs::prelude::*;
 use bevy_input::InputSystem;
 use bevy_transform::TransformSystem;
-use bevy_window::ModifiesWindows;
 use stack::ui_stack_system;
 pub use stack::UiStack;
 use update::update_clipping_system;
@@ -110,7 +109,6 @@ impl Plugin for UiPlugin {
                 widget::text_system
                     .in_base_set(CoreSet::PostUpdate)
                     .before(UiSystem::Flex)
-                    .after(ModifiesWindows)
                     // Potential conflict: `Assets<Image>`
                     // In practice, they run independently since `bevy_render::camera_update_system`
                     // will only ever observe its own render target, and `widget::text_system`
@@ -135,8 +133,7 @@ impl Plugin for UiPlugin {
             .add_system(
                 flex_node_system
                     .in_set(UiSystem::Flex)
-                    .before(TransformSystem::TransformPropagate)
-                    .after(ModifiesWindows),
+                    .before(TransformSystem::TransformPropagate),
             )
             .add_system(ui_stack_system.in_set(UiSystem::Stack))
             .add_system(

crates/bevy_window/src/lib.rs

@@ -137,9 +137,6 @@ impl Plugin for WindowPlugin {
     }
 }
 
-#[derive(Debug, Hash, PartialEq, Eq, Clone, SystemSet)]
-pub struct ModifiesWindows;
-
 /// Defines the specific conditions the application should exit on
 #[derive(Clone)]
 pub enum ExitCondition {

crates/bevy_winit/src/lib.rs

@@ -26,7 +26,7 @@ use bevy_utils::{
 };
 use bevy_window::{
     exit_on_all_closed, CursorEntered, CursorLeft, CursorMoved, FileDragAndDrop, Ime,
-    ModifiesWindows, ReceivedCharacter, RequestRedraw, Window, WindowBackendScaleFactorChanged,
+    ReceivedCharacter, RequestRedraw, Window, WindowBackendScaleFactorChanged,
     WindowCloseRequested, WindowCreated, WindowFocused, WindowMoved, WindowResized,
     WindowScaleFactorChanged,
 };