Skip to content

Commit 7090241

Browse files
Update log_layers_ecs example for children macro (#18293)
# Objective Contributes to #18238 Updates the `log_layers_ecs`, example to use the `children!` macro. Note that I did not use a macro, nor `Children::spawn` for the outer layer. Since the `EventReader` is borrowed mutably, any `.map` I did on `events.read()` was going to have the reference outlive the function body. I believe this scope of change is correct for the PR. ## Solution Updates examples to use the Improved Spawning API merged in #17521 ## Testing - Did you test these changes? If so, how? - Opened the examples before and after and verified the same behavior was observed. I did this on Ubuntu 24.04.2 LTS using `--features wayland`. - Are there any parts that need more testing? - Other OS's and features can't hurt, but this is such a small change it shouldn't be a problem. - How can other people (reviewers) test your changes? Is there anything specific they need to know? - Run the examples yourself with and without these changes. - If relevant, what platforms did you test these changes on, and are there any important ones you can't test? - see above --- ## Showcase n/a ## Migration Guide n/a Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
1 parent 6367ad4 commit 7090241

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

examples/app/log_layers_ecs.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -150,13 +150,16 @@ fn print_logs(
150150

151151
commands.entity(root_entity).with_children(|child| {
152152
for event in events.read() {
153-
child.spawn(Text::default()).with_children(|child| {
154-
child.spawn((
155-
TextSpan::new(format!("{:5} ", event.level)),
156-
TextColor(level_color(&event.level)),
157-
));
158-
child.spawn(TextSpan::new(&event.message));
159-
});
153+
child.spawn((
154+
Text::default(),
155+
children![
156+
(
157+
TextSpan::new(format!("{:5} ", event.level)),
158+
TextColor(level_color(&event.level)),
159+
),
160+
TextSpan::new(&event.message),
161+
],
162+
));
160163
}
161164
});
162165
}

0 commit comments

Comments
 (0)