Add remote cache and CI configs #719

luispadron · 2023-05-10T04:10:57Z

Before this change the CI and cache configs were being generated by .github/workflows/xcode_select.sh which makes it difficult for a contributor to find these and to then apply them.

Changes:

New Bazel configurations that make it easier to reproduce CI setup and debug issues locally.
New configs for testing specific tests that were previously only in the workflow file.
Removes the user.bazelrc generation CI was doing in favor of the new ci and cache configs.
Updates the workflows to use the new configs where needed.

Depends on #716

jszumski

This was always a pain point for me, thank you!

.github/workflows/tests.yml

luispadron · 2023-05-10T15:34:57Z

Someone with Admin access will need to update the required jobs for the branch, if we think the name changes are worth it

mattrobmattrob

Mostly nits. Take it or leave it. This is a great improvement for folks working on the ruleset. 👏

.bazelrc

.github/workflows/tests.yml

mattrobmattrob · 2023-05-10T15:48:28Z

.github/workflows/tests.yml

      - name: Select Xcode
        run: .github/workflows/xcode_select.sh
      - name: Build App
-        run: bazelisk build -s tests/ios/app/App --apple_platform_type=ios --ios_minimum_os=10.2  --ios_multi_cpus=i386,x86_64


Was -s intentionally removed? What did it do?

That prints the subcommands, i meant to add this config:ci. Do we think thats useful, it could be very verbose but its for CI so?

Added this to config=ci as well as --verbose_failures figure its better to be verbose in CI.

thiagohmcruz · 2023-05-10T16:01:12Z

Someone with Admin access will need to update the required jobs for the branch, if we think the name changes are worth it

Probably @justinseanmartin could help here? Where exactly we would have to update those? I've never done that myself 😓

luispadron · 2023-05-10T16:13:44Z

Someone with Admin access will need to update the required jobs for the branch, if we think the name changes are worth it

Probably @justinseanmartin could help here? Where exactly we would have to update those? I've never done that myself 😓

It should be under Settings > Branches > Branch protection > master > Required checks

luispadron · 2023-05-10T16:57:13Z

Weird @thiagohmcruz seeing a similar plist diff now:

-				INFOPLIST_FILE = ../../../tests/ios/frameworks/dynamic/a/Info.plist;

Let me double check I didnt change any underlying flags but its odd

thiagohmcruz · 2023-05-10T17:32:11Z

Yeah, the question is if we even want that plist there since we set it to empty for apps and extensions we might as well be ok with setting it to empty here as well. The things is that removing it causes other issues apparently, I was trying to iterate on that here

luispadron · 2023-05-10T17:39:26Z

@thiagohmcruz Will wait for that PR then!

qyang-nj

Thanks! This hidden user.bazlerc bite me before.

qyang-nj · 2023-05-11T00:16:48Z

.github/workflows/tests.yml

+            --config=ci \
+            -- \
+            //... \
+            -//tests/ios/...


nit: I like this to be on a single line, so that it's easier to copy into to terminal. Same as other commands as well.

luispadron · 2023-05-11T17:16:09Z

I've made some remote_cache changes to improve performance and because I noticed the BES server wasnt set. Let me know if we prefer these in a separate PR though.

luispadron · 2023-05-11T18:09:03Z

@thiagohmcruz fixed the Xcode tests, realized the ci generated rc file set the spawn strategy by default. I've enabled it by default in the main rc file now.

luispadron · 2023-05-11T18:12:24Z

This is ready to merge as soon as we can disable the required jobs that have been renamed.

Once this merges we can enable the new ones.

@thiagohmcruz @justinseanmartin whenever y'all have time or if you want to make me admin I can do it

luispadron · 2023-05-12T18:25:42Z

Actually moving the renaming to a separate PR to not block this further: #722

Applied suggestions from code review Co-authored-by: John Szumski <784312+jszumski@users.noreply.github.com> Co-authored-by: Matt Robinson <mattrob@hey.com>

luispadron force-pushed the lpadron/remove-carthage-cocoapod-rules branch from dc5cae9 to da9a8b3 Compare May 10, 2023 04:15

luispadron force-pushed the lpadron/add-ci-cache-configs branch from 5368ef6 to 47f9d6e Compare May 10, 2023 04:15

luispadron mentioned this pull request May 10, 2023

Add support for bzlmod #703

Merged

luispadron force-pushed the lpadron/add-ci-cache-configs branch from 47f9d6e to 31a3539 Compare May 10, 2023 04:21

jszumski approved these changes May 10, 2023

View reviewed changes

mattrobmattrob reviewed May 10, 2023

View reviewed changes

.github/workflows/tests.yml Outdated Show resolved Hide resolved

Base automatically changed from lpadron/remove-carthage-cocoapod-rules to master May 10, 2023 15:26

luispadron force-pushed the lpadron/add-ci-cache-configs branch from d4e6afb to ba1987c Compare May 10, 2023 15:27

luispadron marked this pull request as ready for review May 10, 2023 15:27

luispadron requested review from jerrymarino, mattrobmattrob and thiagohmcruz May 10, 2023 15:28

mattrobmattrob approved these changes May 10, 2023

View reviewed changes

luispadron force-pushed the lpadron/add-ci-cache-configs branch from e5740af to dba6df6 Compare May 10, 2023 16:19

luispadron mentioned this pull request May 10, 2023

bazel build //tests/ios/xcframeworks/Basic:xcframeworks is failing #720

Closed

luispadron force-pushed the lpadron/add-ci-cache-configs branch from dba6df6 to 452f68e Compare May 10, 2023 17:33

qyang-nj reviewed May 11, 2023

View reviewed changes

luispadron force-pushed the lpadron/add-ci-cache-configs branch 4 times, most recently from a119609 to 8b7df8e Compare May 11, 2023 17:08

luispadron force-pushed the lpadron/add-ci-cache-configs branch from 8b7df8e to 5a2b20b Compare May 11, 2023 17:30

mattrobmattrob approved these changes May 12, 2023

View reviewed changes

luispadron force-pushed the lpadron/add-ci-cache-configs branch from 5a2b20b to 5d700c0 Compare May 12, 2023 18:24

luispadron enabled auto-merge (squash) May 12, 2023 18:26

luispadron force-pushed the lpadron/add-ci-cache-configs branch 2 times, most recently from 75e42ec to ee251ac Compare May 12, 2023 18:29

luispadron and others added 3 commits May 12, 2023 14:31

Add CI and remote cache configurations

eeebf2a

Update tests.yml for CI configs

2e044a9

Applied suggestions from code review Co-authored-by: John Szumski <784312+jszumski@users.noreply.github.com> Co-authored-by: Matt Robinson <mattrob@hey.com>

Update remote_cache configuration with suggestions

9cb5985

luispadron force-pushed the lpadron/add-ci-cache-configs branch from ee251ac to 9cb5985 Compare May 12, 2023 18:31

luispadron disabled auto-merge May 12, 2023 18:32

luispadron enabled auto-merge (squash) May 12, 2023 18:32

luispadron merged commit 64d3c8b into master May 12, 2023

luispadron deleted the lpadron/add-ci-cache-configs branch May 12, 2023 19:09

Add remote cache and CI configs #719

Add remote cache and CI configs #719

Uh oh!

Conversation

luispadron commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jszumski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luispadron commented May 10, 2023

Uh oh!

mattrobmattrob left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattrobmattrob May 10, 2023

Choose a reason for hiding this comment

Uh oh!

luispadron May 10, 2023

Choose a reason for hiding this comment

Uh oh!

luispadron May 10, 2023

Choose a reason for hiding this comment

Uh oh!

thiagohmcruz commented May 10, 2023

Uh oh!

luispadron commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luispadron commented May 10, 2023

Uh oh!

thiagohmcruz commented May 10, 2023

Uh oh!

luispadron commented May 10, 2023

Uh oh!

qyang-nj left a comment

Choose a reason for hiding this comment

Uh oh!

qyang-nj May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luispadron commented May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luispadron commented May 11, 2023

Uh oh!

luispadron commented May 11, 2023

Uh oh!

luispadron commented May 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

luispadron commented May 10, 2023 •

edited

Loading

luispadron commented May 10, 2023 •

edited

Loading

qyang-nj May 11, 2023 •

edited

Loading

luispadron commented May 11, 2023 •

edited

Loading