Remove Carthage and Cocoapod rules #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
lpadron/remove-carthage-cocoapod-rules
branch
2 times, most recently
from
2bb03bb to
668e9d4
Compare
mattrobmattrob
approved these changes
May 9, 2023
Collaborator
mattrobmattrob
left a comment
mattrobmattrob
left a comment
There was a problem hiding this comment.
Removal of --deleted_packages='' is 🔥
luispadron
force-pushed
the
lpadron/remove-carthage-cocoapod-rules
branch
from
c56baf9 to
0de5312
Compare
jszumski
approved these changes
May 9, 2023
jerrymarino
approved these changes
May 9, 2023
Contributor
jerrymarino
left a comment
jerrymarino
left a comment
There was a problem hiding this comment.
LGTM - thanks for cleaning this up!
luispadron
force-pushed
the
lpadron/remove-carthage-cocoapod-rules
branch
2 times, most recently
from
b67df7e to
dc5cae9
Compare
luispadron
force-pushed
the
lpadron/remove-carthage-cocoapod-rules
branch
from
dc5cae9 to
da9a8b3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two rules require a fair amount of maintenance and constantly break between large changes like Bazel / Xcode upgrades. In the interest of the health of
rules_ioswe believe these should be deprecated in favor of other community rules which do similar things.This change should help the
rules_ioscontributors more easily make changes without maintaining rules that aren't used by many folks.If you do use these rules and depend on it and don't agree with this direction, please let us know!