Skip to content

Add remote cache and CI configs #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luispadron merged 3 commits into from
May 12, 2023
Merged

Add remote cache and CI configs #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eeebf2a
Add CI and remote cache configurations
luispadron May 10, 2023
2e044a9
Update tests.yml for CI configs
luispadron May 10, 2023
9cb5985
Update remote_cache configuration with suggestions
luispadron May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 58 additions & 6 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@
# so circumvent by not using the sandbox
build --strategy=Stardoc=standalone

# Debugging does not work in sandbox mode. Uncomment these lines to turn off sandboxing.
# build --genrule_strategy=standalone
# build --spawn_strategy=standalone
# Spawn strategy required for some tests
build --spawn_strategy=standalone

# Setup Xcode configuration for xcodeproj tests
build --xcode_version_config=//:host_xcodes

build --verbose_failures # Print the full command line for commands that failed
build --test_output=errors # Prints log file output to the console on failure
Expand All @@ -28,14 +30,64 @@ build --test_env=PATH=/usr/bin:/bin:/usr/sbin:/sbin
# Bazel 5 - matches ios_sim_arm64 CPU, Bazel 4 - needs "override" flags
build --features apple.arm64_simulator_use_device_deps

# Note - tree artifacts needs to be on
build:lldb_ios_test --spawn_strategy=standalone --apple_platform_type=ios --define=apple.experimental.tree_artifact_outputs=1

# Delete the VM test suite for github
build --deleted_packages tests/ios/vmd

# Allow for server to start (GitHub actions can timeout)
startup --local_startup_timeout_secs=240

# - iOS Configuration
# Required for tests/ios/... targets
build:ios --apple_platform_type=ios

# - VFS configuration
# Required for some tests in tests/ios/... targets
build:vfs --features=apple.virtualize_frameworks

# - iOS lldb test configuration
build:ios_lldb_test --config=ios
build:ios_lldb_test --define=apple.experimental.tree_artifact_outputs=1

# - iOS multi arch test configuration
build:ios_multi_arch_test --config=ios
build:ios_multi_arch_test --ios_minimum_os=10.2
build:ios_multi_arch_test --ios_multi_cpus=i386,x86_64

# - Remote cache configuration
build:remote_cache --bes_backend=grpcs://remote.buildbuddy.io
build:remote_cache --bes_results_url=https://app.buildbuddy.io/invocation/
build:remote_cache --experimental_build_event_upload_strategy=local
build:remote_cache --experimental_remote_cache_compression
build:remote_cache --experimental_remote_merkle_tree_cache
build:remote_cache --modify_execution_info=^(BitcodeSymbolsCopy|BundleApp|BundleTreeApp|DsymDwarf|DsymLipo|GenerateAppleSymbolsFile|ObjcBinarySymbolStrip|CppLink|ObjcLink|ProcessAndSign|SignBinary|SwiftArchive|SwiftStdlibCopy)$=+no-remote,^(BundleResources|ImportedDynamicFrameworkProcessor)$=+no-remote-exec
build:remote_cache --nolegacy_important_outputs
build:remote_cache --noslim_profile
build:remote_cache --remote_cache=grpcs://remote.buildbuddy.io
build:remote_cache --remote_timeout=3600

# Enable remote_cache config by default
build --config=remote_cache

# By default don't upload local results to remote cache, only CI does this.
build --noremote_upload_local_results
build:ci --remote_upload_local_results

# - CI Configuration
# disable curses control since CI logs are not interactive
common:ci --curses=no
# turn off loading message updates
common:ci --noshow_loading_progress
# throttle progress updates in CI as they can clutter the logs
common:ci --show_progress_rate_limit=15.0
build:ci --progress_report_interval=60
# enable more verbose logging
build:ci --verbose_failures
build:ci --subcommands
# ci setup for tests, tend to be more flaky on github actions
build:ci --jobs=4
test:ci --test_timeout=600
test:ci --flaky_test_attempts=//tests/ios/...@3
test:ci --local_test_jobs=1

# Load a user.bazelrc
try-import %workspace%/user.bazelrc
98 changes: 73 additions & 25 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,33 @@ jobs:
run: .github/workflows/xcode_select.sh
- name: Build and Test
run: |
# Host config
bazelisk test --local_test_jobs=1 -- //... -//tests/ios/...
# non-iOS tests
bazelisk test \
--config=ci \
-- \
//... \
-//tests/ios/...
Copy link
Contributor

@qyang-nj qyang-nj May 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I like this to be on a single line, so that it's easier to copy into to terminal. Same as other commands as well.


# Clean up after simctl (https://github.com/bazelbuild/rules_apple/issues/185)
pgrep Simulator | xargs kill || true

# Create single ephemeral iOS sim
SIMULATOR_UDID=$(./tools/tests/prepare_sim.py)

# iOS tests
bazelisk test \
--local_test_jobs=1 \
--apple_platform_type=ios \
--config=ci \
--config=ios \
--test_arg=--destination=platform=ios_simulator,id=$SIMULATOR_UDID \
-- //tests/ios/...
-- \
//tests/ios/...

- uses: actions/upload-artifact@v2
if: failure()
with:
name: bazel-testlogs
path: bazel-testlogs

build_virtual_frameworks:
# Build the entire tree with this feature enabled. Longer term, we'll likely
# consider merging this feature into the default behavior and can re-align
Expand All @@ -52,13 +60,21 @@ jobs:
run: .github/workflows/xcode_select.sh
- name: Build and Test
run: |
# Host config
bazelisk build --features apple.virtualize_frameworks --local_test_jobs=1 -- //... -//tests/ios/...
# non-iOS tests
bazelisk test \
--config=ci \
--config=vfs \
-- \
//... \
-//tests/ios/...

bazelisk build --features apple.virtualize_frameworks \
--local_test_jobs=1 \
--apple_platform_type=ios \
-- //tests/ios/...
# iOS tests
bazelisk test \
--config=ci \
--config=ios \
--config=vfs \
-- \
//tests/ios/...

- uses: actions/upload-artifact@v2
if: failure()
Expand All @@ -69,16 +85,22 @@ jobs:
lts_ios_integration_tests:
name: Build and Test ( Virtual Frameworks + LTS )
runs-on: macos-12
env:
USE_BAZEL_VERSION: 5.3.2
steps:
- uses: actions/checkout@v3
- name: Select Xcode
run: .github/workflows/xcode_select.sh
- name: Build and Test
run: |
export USE_BAZEL_VERSION=5.3.2
bazelisk build --features apple.virtualize_frameworks \
--config=ios \
-- //tests/ios/...
# iOS tests
bazelisk build \
--config=ci \
--config=ios \
--config=vfs \
-- \
//tests/ios/...

- uses: actions/upload-artifact@v2
if: failure()
with:
Expand All @@ -95,25 +117,31 @@ jobs:
- name: Build and Test
run: |
bazelisk build \
--config=ci \
--config=vfs \
--ios_multi_cpus=sim_arm64 \
--features apple.virtualize_frameworks \
-- //... -//tests/ios/...
-- \
//... \
-//tests/ios/...

# Misc issues:
# - Fails on a non fat framework for //tests/ios/unit-test/test-imports-app/
bazelisk build \
--config=ci \
--config=ios \
--config=vfs \
--ios_multi_cpus=sim_arm64 \
--features apple.virtualize_frameworks \
--apple_platform_type=ios \
-- //tests/ios/... -//tests/ios/unit-test/test-imports-app/...
-- \
//tests/ios/... \
-//tests/ios/unit-test/test-imports-app/...

- uses: actions/upload-artifact@v2
if: failure()
with:
name: bazel-testlogs
path: bazel-testlogs

buildifier:
lint:
name: Check Starlark and Docs
runs-on: macos-12
steps:
Expand All @@ -122,9 +150,16 @@ jobs:
run: .github/workflows/xcode_select.sh
# Note: we need to pass the absolute to the Bazel run
- name: buildifier
run: find $PWD -type f \( -name 'WORKSPACE' -o -name '*.bzl' -o -name '*.bazel' \) | xargs bazel run buildifier -- -lint=fix && git diff --exit-code
run: |
find $PWD -type f \( -name 'WORKSPACE' -o -name '*.bzl' -o -name '*.bazel' \) | xargs bazel run //:buildifier -- -lint=fix
git diff --exit-code
- name: Check docs
run: bazelisk run docs && git diff --exit-code docs
run: |
bazelisk run \
--config=ci \
//docs
git diff --exit-code docs

xcodeproj_tests:
name: .xcodeproj Tests on Xcode 14.2.0
runs-on: macos-12
Expand All @@ -148,12 +183,20 @@ jobs:
- name: Select Xcode 14.2.0
run: .github/workflows/xcode_select.sh
- name: Run tests
run: bazelisk test tests/ios/lldb/app:objc_app_po_test tests/ios/lldb/app:objc_app_variable_test --config lldb_ios_test
run: |
bazelisk test \
--config=ci \
--config=ios_lldb_test \
-- \
tests/ios/lldb/app:objc_app_po_test \
tests/ios/lldb/app:objc_app_variable_test

- uses: actions/upload-artifact@v2
if: failure()
with:
name: bazel-testlogs
path: bazel-testlogs

multi_arch_support:
name: Build iOS App for Multiple Architecture
runs-on: macos-12
Expand All @@ -162,4 +205,9 @@ jobs:
- name: Select Xcode
run: .github/workflows/xcode_select.sh
- name: Build App
run: bazelisk build -s tests/ios/app/App --apple_platform_type=ios --ios_minimum_os=10.2 --ios_multi_cpus=i386,x86_64
Copy link
Collaborator

@mattrobmattrob mattrobmattrob May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was -s intentionally removed? What did it do?

Copy link
Collaborator Author

@luispadron luispadron May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That prints the subcommands, i meant to add this config:ci. Do we think thats useful, it could be very verbose but its for CI so?

Copy link
Collaborator Author

@luispadron luispadron May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this to config=ci as well as --verbose_failures figure its better to be verbose in CI.

run: |
bazelisk build \
--config=ci \
--config=ios_multi_arch_test \
-- \
tests/ios/app/App
17 changes: 0 additions & 17 deletions .github/workflows/xcode_select.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,3 @@ printenv

sudo xcode-select -p
sudo xcode-select -s /Applications/Xcode_14.2.app

echo "Generating bazelrc"

# Setup for github actions - these are very flaky
echo "test --test_timeout=600 --flaky_test_attempts=//tests/ios/...@3" > user.bazelrc
echo "test --local_test_jobs=1" >> user.bazelrc

echo "build --jobs=4" >> user.bazelrc
echo "build --spawn_strategy=standalone" >> user.bazelrc
echo "build --xcode_version_config=//:host_xcodes" >> user.bazelrc

echo "build:ios --apple_platform_type=ios" >> user.bazelrc

# Remote cache
echo "build --remote_cache=grpcs://remote.buildbuddy.io" >> user.bazelrc
echo "build --remote_timeout=3600" >> user.bazelrc
echo "build --modify_execution_info=^(BitcodeSymbolsCopy|BundleApp|BundleTreeApp|DsymDwarf|DsymLipo|GenerateAppleSymbolsFile|ObjcBinarySymbolStrip|CppLink|ObjcLink|ProcessAndSign|SignBinary|SwiftArchive|SwiftStdlibCopy)$=+no-remote,^(BundleResources|ImportedDynamicFrameworkProcessor)$=+no-remote-exec" >> user.bazelrc