Skip to content

Switch CODEOWNERS from sip to cli team#346

Merged
jeremy merged 2 commits intomainfrom
switch-codeowners-to-cli-team
Mar 18, 2026
Merged

Switch CODEOWNERS from sip to cli team#346
jeremy merged 2 commits intomainfrom
switch-codeowners-to-cli-team

Conversation

@jeremy
Copy link
Copy Markdown
Member

@jeremy jeremy commented Mar 18, 2026

Reduces review noise for the sip team by routing ownership to the cli team.


Summary by cubic

Switch CODEOWNERS and release env reviewers from @basecamp/sip to @basecamp/cli to route reviews to the CLI team and reduce SIP noise.
Updates .github/CODEOWNERS (default, .goreleaser.yaml, .github/workflows/, scripts/release.sh) and scripts/manage-release-env.sh.

Written for commit 1bbaaf3. Summary will update on new commits.

@jeremy jeremy requested a review from a team as a code owner March 18, 2026 19:21
Copilot AI review requested due to automatic review settings March 18, 2026 19:21
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

Sensitive Change Detection (shadow mode)

This PR modifies control-plane files:

  • .github/CODEOWNERS
  • scripts/manage-release-env.sh

Shadow mode — this check is informational only. When activated, changes to these paths will require approval from a maintainer.

@github-actions github-actions bot added the ci CI/CD workflows label Mar 18, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 18, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Routes repository ownership from @basecamp/sip to @basecamp/cli in CODEOWNERS to reduce review noise for the sip team and ensure the cli team receives relevant review requests.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Changes:

  • Update the global * CODEOWNERS rule to @basecamp/cli.
  • Update ownership for release/config-related paths to @basecamp/cli.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0900908fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jeremy jeremy requested a review from Copilot March 18, 2026 19:35
@github-actions github-actions bot added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Mar 18, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates repository ownership and release-environment reviewer routing from @basecamp/sip to @basecamp/cli, aligning review requests with the CLI team and reducing SIP team noise.

Changes:

  • Update .github/CODEOWNERS to assign ownership to @basecamp/cli.
  • Update scripts/manage-release-env.sh manifest entries to use basecamp/cli as the required reviewer team.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/manage-release-env.sh Routes release environment required reviewers to the CLI team via the repo manifest.
.github/CODEOWNERS Changes default and specific-path code ownership to @basecamp/cli.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jeremy jeremy merged commit 59d1d01 into main Mar 18, 2026
30 checks passed
@jeremy jeremy deleted the switch-codeowners-to-cli-team branch March 18, 2026 19:38
jeremy added a commit to brianevanmiller/basecamp-cli that referenced this pull request Mar 18, 2026
…evanmiller/feature-gap-analysis

* origin/main:
  Show full content in detail views instead of truncating at 40 chars (basecamp#338)
  Switch CODEOWNERS from sip to cli team (basecamp#346)
  Fix dock ordering and add --all flag to `projects show` (basecamp#333)
  Add file upload command to SKILL.md (basecamp#343)
  Replace "pending" with "incomplete" in todos output; omit from default view (basecamp#327)
  Add `--in` as global alias for `--project` (basecamp#334)
  Fix 3 post-QA issues on api command (basecamp#330)
  deps: bump the go-dependencies group with 2 updates (basecamp#331)
  Improve tool instance disambiguation format (basecamp#329)
  Fix emoji/CJK alignment in search results (basecamp#328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD workflows enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants