Improve tool instance disambiguation format

[jeremy]

Summary

• Reformats multi-tool disambiguation errors so the ID comes first and is easy to copy-paste into --flag <id>:

  Multiple message boards found. Specify one with --board <id>:
    12345  General
    67890  Engineering
  

• All three code paths that produce these errors now use the same format: getDockToolID, multiToolError (TUI resolver), and getCardTableID
• Fixes pluralization for irregular nouns (inbox → inboxes, not inboxs) via a pluralNoun helper
• Removes the now-unused formatCardTableMatches function

Test plan

• Existing tests updated for new format
• New tests for inbox (irregular plural) on both command and TUI resolver paths
• pluralNoun unit test covers all tool-related nouns
• bin/ci passes

---

Summary by cubic

Standardizes multi-tool disambiguation errors to "Multiple found" with ID-first lines and a clear flag hint, making copy-paste easier in CLI and TUI. Consolidates pluralization into output.PluralNoun to fix cases like inbox → inboxes.

• Refactors
  • Unified error format in getDockToolID, multiToolError, and getCardTableID: "Multiple found" + "Specify one with -- :" + lines like " <title>".
  • Moved pluralization to shared output.PluralNoun used by CLI and TUI.
  • Removed unused formatCardTableMatches; updated tests for new messages, hints, and pluralization.

^{Written for commit 312f254. Summary will update on new commits.}

[Copilot]

Pull request overview

This PR standardizes ambiguous “multiple matches” errors for dock tools (commands + TUI resolver) and card tables so IDs appear first in a copy/paste-friendly list, and improves pluralization for tool nouns (including inbox → inboxes).

Changes:

• Reformats ambiguous multi-tool errors to: Multiple <plural> found + Specify one with --<flag> <id>: + <id> <title> entries.
• Adds a small pluralization helper and tests to cover irregular plurals like “inboxes”.
• Updates/extends tests and removes the now-unused formatCardTableMatches helper.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/tui/resolve/dock.go	Updates TUI resolver ambiguous error formatting; adds pluralization helper for tool nouns.
internal/tui/resolve/dock_test.go	Updates assertions for new format and adds inbox pluralization coverage.
internal/commands/helpers.go	Updates getDockToolID ambiguous error formatting; adds pluralNoun.
internal/commands/helpers_test.go	Updates assertions and adds tests for inbox plural + pluralNoun cases.
internal/commands/todos_test.go	Updates ambiguous todoset error assertions to match the new format.
internal/commands/cards.go	Updates multi-card-table ambiguity to match the standardized format; removes formatCardTableMatches.
internal/commands/cards_test.go	Removes tests for deleted helper; updates ambiguity assertions for new card table format.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cubic-dev-ai]

2 issues found across 7 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/tui/resolve/dock_test.go">

<violation number="1" location="internal/tui/resolve/dock_test.go:115">
P2: Missing `e.Code` assertion — the sibling `TestDockToolMultiNonInteractiveError` verifies `output.CodeAmbiguous` but this test does not. Add the same check so the error code is covered for the inbox path.</violation>
</file>

<file name="internal/tui/resolve/dock.go">

<violation number="1" location="internal/tui/resolve/dock.go:178">
P2: `pluralizeName` duplicates the identical `pluralNoun` function in `internal/commands/helpers.go`. Consider extracting this into a shared package (e.g., `internal/text` or `internal/output`) so both call sites use the same function and future pluralization fixes only need to be applied once.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}