Show full content in detail views instead of truncating at 40 chars#338
Merged
Show full content in detail views instead of truncating at 40 chars#338
Conversation
The generic formatCell function truncates all non-URL strings to 40 display characters, which is appropriate for table rows but wrong for detail views like `basecamp show`. A message's content field — often the thing you're trying to read — was getting cut to 40 chars. Add formatDetailValue for renderObject (detail/single-object views) that preserves full string content while still applying ANSI stripping, HTML-to-Markdown conversion, and newline collapsing. Date formatting and table/list truncation are unchanged.
There was a problem hiding this comment.
Pull request overview
This PR fixes detail views (basecamp show) truncating content at 40 characters by introducing formatDetailValue, which preserves full string content while maintaining ANSI stripping, HTML→Markdown conversion, and newline collapsing.
Changes:
- Added
formatDetailValuefunction that formats values for single-object detail views without truncation - Updated both
renderObject(styled) andMarkdownRenderer.renderObjectto useformatDetailValueinstead offormatDateValue
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
jeremy
approved these changes
Mar 18, 2026
jeremy
added a commit
to brianevanmiller/basecamp-cli
that referenced
this pull request
Mar 18, 2026
…evanmiller/feature-gap-analysis * origin/main: Show full content in detail views instead of truncating at 40 chars (basecamp#338) Switch CODEOWNERS from sip to cli team (basecamp#346) Fix dock ordering and add --all flag to `projects show` (basecamp#333) Add file upload command to SKILL.md (basecamp#343) Replace "pending" with "incomplete" in todos output; omit from default view (basecamp#327) Add `--in` as global alias for `--project` (basecamp#334) Fix 3 post-QA issues on api command (basecamp#330) deps: bump the go-dependencies group with 2 updates (basecamp#331) Improve tool instance disambiguation format (basecamp#329) Fix emoji/CJK alignment in search results (basecamp#328)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
basecamp showtruncates content/description fields to 40 characters becauserenderObjectuses the sameformatCellpath as table rowsformatDetailValuefor detail (single-object) views that preserves fullstring content while keeping ANSI stripping, HTML→Markdown, and newline collapsing
formatCellstill caps at 40 charsBefore:
Content: **This message affects US Employees o...After: full content rendered
Summary by cubic
Show full content in detail views (e.g.,
basecamp show) instead of truncating at 40 characters, so message bodies are fully readable while keeping existing formatting rules.formatDetailValuefor detail views and use it in both styled and markdown renderers to preserve full strings.formatDateValuewith newisDateColumnhelper.formatCellcaps at 40 chars); added tests to verify no truncation and HTML→Markdown in detail views.Written for commit e04384b. Summary will update on new commits.