Merge Geth v1.13.15 #232
Merged
Merge Geth v1.13.15 #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.13.8
Release 1.13.11
…879) This adds an error if the signer returns a nil value for one of the signature value fields.
The hyperlink in the README file that directs to the Travis CI build was broken. This commit updates the link to point to the corrent build page.
At some point, `ForkchoiceUpdatedV2` stopped working for `PayloadAttributesV1` while `paris` was active. This was causing a few failures in hive. This PR fixes that, and also adds a gate in `ForkchoiceUpdatedV1` to disallow `PayloadAttributesV3`.
This pull request resets the txlookup cache if chain reorg happens, preventing them from remaining reachable. It addresses failures in the hive tests.
* eth/downloader: fix skeleton cleanup * eth/downloader: short circuit if nothing to delete * eth/downloader: polish the logic in cleanup * eth/downloader: address comments
… (#28914) * core/txpool/blobpool: clean up resurrected junk after a crash * core/txpool/blobpool: track transaction insertions and rejections * core/txpool/blobpool: linnnnnnnt
…er (#28917) * core/txpool: don't inject lazy resolved transactions into the container * core/txpool: minor typo fixes
Co-authored-by: Martin HS <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com>
* eth, miner: fix enforcing the minimum miner tip * ethclient/simulated: fix failing test due the min tip change * accounts/abi/bind: fix simulater gas tip issue
* all: implement era format, add history importer/export * internal/era/e2store: refactor e2store to provide ReadAt interface * internal/era/e2store: export HeaderSize * internal/era: refactor era to use ReadAt interface * internal/era: elevate anonymous func to named * cmd/utils: don't store entire era file in-memory during import / export * internal/era: better abstraction between era and e2store * cmd/era: properly close era files * cmd/era: don't let defers stack * cmd/geth: add description for import-history * cmd/utils: better bytes buffer * internal/era: error if accumulator has more records than max allowed * internal/era: better doc comment * internal/era/e2store: rm superfluous reader, rm superfluous testcases, add fuzzer * internal/era: avoid some repetition * internal/era: simplify clauses * internal/era: unexport things * internal/era,cmd/utils,cmd/era: change to iterator interface for reading era entries * cmd/utils: better defer handling in history test * internal/era,cmd: add number method to era iterator to get the current block number * internal/era/e2store: avoid double allocation during write * internal/era,cmd/utils: fix lint issues * internal/era: add ReaderAt func so entry value can be read lazily Co-authored-by: lightclient <lightclient@protonmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * internal/era: improve iterator interface * internal/era: fix rlp decode of header and correctly read total difficulty * cmd/era: fix rebase errors * cmd/era: clearer comments * cmd,internal: fix comment typos --------- Co-authored-by: Martin Holst Swende <martin@swende.se>
AnnaShaleva
force-pushed
the
upd-v1.13.15
branch
from
203f161 to
6b4fb66
Compare
msg.GasTipCap is nil, but I'm not sure why, it shouldn't be like that
in the real network.
```
--- FAIL: TestExecutionSpecState (0.01s)
--- FAIL: TestExecutionSpecState/berlin/eip2930_access_list/acl/access_list.json (0.00s)
--- FAIL: TestExecutionSpecState/berlin/eip2930_access_list/acl/access_list.json/tests/berlin/eip2930_access_list/test_acl.py::test_access_list[fork_Berlin-state_test] (0.00s)
--- FAIL: TestExecutionSpecState/berlin/eip2930_access_list/acl/access_list.json/tests/berlin/eip2930_access_list/test_acl.py::test_access_list[fork_Berlin-state_test]/Berlin/0/hash/trie (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x5e2ad8]
goroutine 78973 [running]:
testing.tRunner.func1.2({0xd79340, 0x162a1b0})
/usr/local/go/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
/usr/local/go/src/testing/testing.go:1634 +0x377
panic({0xd79340?, 0x162a1b0?})
/usr/local/go/src/runtime/panic.go:770 +0x132
math/big.(*Int).Cmp(0x0?, 0x0?)
/usr/local/go/src/math/big/int.go:381 +0x18
github.com/ethereum/go-ethereum/core.(*StateTransition).preCheck(0xc001317628)
/home/anna/Documents/GitProjects/bane-labs/go-ethereum/core/state_transition.go:300 +0x485
github.com/ethereum/go-ethereum/core.(*StateTransition).TransitionDb(0xc001317628)
/home/anna/Documents/GitProjects/bane-labs/go-ethereum/core/state_transition.go:393 +0x51
github.com/ethereum/go-ethereum/core.ApplyMessage(0x0?, 0xf97800?, 0xf96f28?)
/home/anna/Documents/GitProjects/bane-labs/go-ethereum/core/state_transition.go:184 +0x57
github.com/ethereum/go-ethereum/tests.(*StateTest).RunNoVerify(0xc0001794a0, {{0xc000353730?, 0xc001142006?}, 0x7dc007fd8a68?}, {{0x0, 0x0}, 0x0, 0x0, {0x0, 0x0, ...}}, ...)
/home/anna/Documents/GitProjects/bane-labs/go-ethereum/tests/state_test_util.go:301 +0x9e5
github.com/ethereum/go-ethereum/tests.(*StateTest).Run(0xc0001794a0, {{0xc000353730?, 0x6?}, 0x0?}, {{0x0, 0x0}, 0x0, 0x0, {0x0, 0x0, ...}}, ...)
/home/anna/Documents/GitProjects/bane-labs/go-ethereum/tests/state_test_util.go:198 +0xf7
github.com/ethereum/go-ethereum/tests.execStateTest.func1.1({{0x0, 0x0}, 0x0, 0x0, {0x0, 0x0, 0x0}})
/home/anna/Documents/GitProjects/bane-labs/go-ethereum/tests/state_test.go:113 +0xef
github.com/ethereum/go-ethereum/tests.withTrace(0xc001129520, 0x4ef00, 0xc001317f18)
/home/anna/Documents/GitProjects/bane-labs/go-ethereum/tests/state_test.go:167 +0x75
github.com/ethereum/go-ethereum/tests.execStateTest.func1(0xc001129520)
/home/anna/Documents/GitProjects/bane-labs/go-ethereum/tests/state_test.go:111 +0x12b
testing.tRunner(0xc001129520, 0xc002c0d350)
/usr/local/go/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 78972
/usr/local/go/src/testing/testing.go:1742 +0x390
```
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Support for eth/67 was dropped in 8a76a81. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
core: fix filing test after v1.13.15 merge
Member
Author
|
Tests pass, but privnet isn't running: I'm fixing it. @txhsl, @chenquanyu from your side regarding base fee changes I need you to take a look at ethereum/go-ethereum#28933 and ethereum/go-ethereum#29005 and check whether we need to adjust fees related code. From my PoW we can go without any additional changes, but may be I'm wrong. |
Contributor
Yes, I think we can go without any additional changes. I'm glad to see that a minimum fee setting was finally applied to the blob pool, it made the codes reasonable. But before we enable the blob transactions when release v0.2.2, we need to apply our policy limit to the pool properly, ref #266. |
Member
Author
Regarding this problem:
|
Contributor
It is hard to figure out the reason, since the only log we can see is |
Member
Author
Just to clarify: I don’t think it’s the contract’s fault. It looks like something has been changed in the VM processors. |
Contributor
|
Just some results, I tried several test cases about
|
txhsl
reviewed
Aug 14, 2024
Partially revert ethereum/go-ethereum#29023. This commit intentionally breaks the post-merge hardforks logic to fix the problem described in #232 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Member
Author
|
Let me do the final checks with mainnet/testnet sync. |
Member
Author
|
Mainnet sync passes: Testnet sync passes, although testnet sync is significantly slower than it should be due to #296, will fix it in another PR. Ready for the merge. |
Member
Author
|
@txhsl, @roman-khimov, please review&merge. |
roman-khimov
approved these changes
Aug 14, 2024
Contributor
roman-khimov
left a comment
roman-khimov
left a comment
There was a problem hiding this comment.
Can't say much about upstream changes, but adaptation is rather clear and if tests are fine then it's OK.
txhsl
approved these changes
Aug 15, 2024
Contributor
|
Will merge this after some necessary tests from our side. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges v1.13.15 of Geth into bane-main and aimed to close #188.
Close #291.
UPD on the compatibility problem described earlier: there's actually no compatibility problems with the 1.13.15 version merge. Turns out that Geth v1.13.15 was an unclean release from non-master branch. It's based on v1.13.14 with five additional commits cherry-picked (ref. ethereum/go-ethereum#29556, the release branch itself is https://github.com/ethereum/go-ethereum/tree/release/1.13).
The list of important PRs that were merged. @txhsl, @chenquanyu, please take a look at these PRs before the review.
Also, it would be nice if you double-check the merged commits, maybe you'll find something important that we should react to.