core/txpool, eth, miner: pre-filter dynamic fees during pending tx retrieval #29005
+79
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was found by @MariusVanDerWijden!
This PR fixes a number of performance bugs in the transaction pool pending retrieval:
enforceTips
flag because useless, as it had no access to the miner's tip any more. This PR also fixes that with the passed parameter.Benchmarks: