Merge pull request #292 from bane-labs/fix-request-tx

Improve `RequestTx` dBFT callback implementation

Author: roman-khimov

consensus/dbft/dbft.go

@@ -402,9 +402,7 @@ func New(config *params.DBFTConfig, _ ethdb.Database) (*DBFT, error) {
 			}
 
 			var sorted = make([]common.Hash, len(hashes))
-			for i := range hashes {
-				sorted[i] = hashes[i]
-			}
+			copy(sorted, hashes)
 			sort.Slice(sorted, func(i, j int) bool {
 				return sorted[i].Cmp(sorted[j]) < 0
 			})

eth/handler.go

@@ -768,7 +768,7 @@ func (h *handler) BroadcastRequestTxs(txHashes []common.Hash) {
 		}
 		// Broadcast RequestTxs
 		for _, peer := range peers {
-			err := peer.RequestTxs(txHashes)
+			err := peer.RequestTxs(txHashes[start:stop])
 			if err != nil {
 				log.Error("BroadcastRequestTxs", "txHashes", txHashes,
 					"peer", peer.ID(),