Legacy services clean up

[PyvesB]

This will hopefully allow us to close #2863!

[shields-ci]

	Warnings
⚠️	This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?

	Messages
📖	✨ Thanks for your contribution to Shields, @PyvesB!
📖	Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against 926f409

[platan]

LGTM
Should we do something with this?

shields/core/base-service/legacy-request-handler.js

Lines 109 to 113 in 07a8d2e

	// When the legacy services have been rewritten, all the code in here
	// will go away, which should achieve this goal in a simpler way.
	//
	// Ref: https://github.com/badges/shields/pull/2755
	function setCacheHeadersOnResponse(res, serviceOverrideCacheLengthSeconds) {

[PyvesB]

@platan I believe we'll be able to start work on rewriting the request handler now that the legacy services are gone. 😉

[paulmelnikow]

😁

[paulmelnikow]

This document has a lot of good content related to best practices for new-style services. Rather than delete it, I'd like to rework it into a design document.

Could you reset this file and then we can deal with that in a follow on?

If you want you could add a note at the top that the document is out of date and needs to be updated, so people take it with a grain of salt.

[PyvesB]

Done.

[paulmelnikow]

😁

[paulmelnikow]

@PyvesB @platan I opened #3368 with a couple comments about rewriting the request handler.

[shields-deployment]

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

[chris48s]

bye bye stuff we don't need any more 👋

I find it slightly disappointing that this PR doesn't delete many hundreds of lines of terrible code we don't want any more, but maybe its a reflection of the fact that wrapping the legacy code up in LegacyService classes allowed us to clean a lot of core up in parallel with the service refactoring :)

[paulmelnikow]

Ha! In part that is true though I think there is a lot of that yet to come. So far there are #3371 #3392, and there's #3368 #3328 #3329 yet to do… all of which has been blocking on this, more or less.