Legacy services clean up

README.md

@@ -16,9 +16,6 @@
     <a href="https://circleci.com/gh/badges/daily-tests">
         <img src="https://img.shields.io/circleci/project/github/badges/daily-tests.svg?label=service%20tests"
             alt="service-test status"></a>
-    <a href="https://docs.google.com/spreadsheets/d/1cHIUSVaiKrIFw3KIu0yt-EMNlMkIfU5alE7YKZ4PeOE/edit#gid=0">
-        <img src="https://img.shields.io/github/search/badges/shields/extends%20LegacyService.svg?label=legacy%20services%20needing%20refactor"
-            alt="legacy services needing refactor"></a>
     <a href="https://coveralls.io/github/badges/shields">
         <img src="https://img.shields.io/coveralls/github/badges/shields.svg"
             alt="coverage"></a>

core/base-service/base.js

@@ -184,14 +184,8 @@ module.exports = class BaseService {
 
   static getDefinition() {
     const { category, name, isDeprecated } = this
-
-    let base, format, pattern, queryParams
-    try {
-      ;({ base, format, pattern } = this.route)
-      queryParams = getQueryParamNames(this.route)
-    } catch (e) {
-      // Legacy services do not have a route.
-    }
+    const { base, format, pattern } = this.route
+    const queryParams = getQueryParamNames(this.route)
 
     const examples = this.examples.map((example, index) =>
       transformExample(example, index, this)

package.json

@@ -110,7 +110,6 @@
     "start": "concurrently --names server,frontend \"npm run start:server\" \"cross-env GATSBY_BASE_URL=http://localhost:8080 gatsby develop --port 3000\"",
     "e2e": "start-server-and-test start http://localhost:3000 test:e2e",
     "e2e-on-build": "cross-env CYPRESS_baseUrl=http://localhost:8080 start-server-and-test start:server http://localhost:8080 test:e2e",
-    "refactoring-report": "node scripts/refactoring-cli.js",
     "badge": "cross-env NODE_CONFIG_ENV=test TRACE_SERVICES=true node scripts/badge-cli.js"
   },
   "lint-staged": {