Deprecate route format, replacing with pattern

[paulmelnikow]

To make the code easier to understand and to support trie-based routing for #3328, it would be helpful to replace the several remaining instances of route formats with patterns.

Many of the remaining formats are designed to support aliases, and since we've started using redirects heavily, the likely solution is to rewrite the canonical form using a pattern, and add redirects for each of the alias forms.

Ideally by using multiple redirects we can rewrite everything using patterns.

[paulmelnikow]

With the PRs for #3714 merged, outside of legacy redirectors there aren't many of these left!

[calebcartwright]

One of the last remaining non-redirect ones is Wercker. I've sat down twice now to attempt to convert but it's a bit of an 👀 popper.

shields/services/wercker/wercker.service.js

Lines 22 to 29 in ddbe19f

	static get route() {
	return {
	base: 'wercker',
	format:
	'(?:(?:ci/)([a-fA-F0-9]{24})|(?:build|ci)/([^/]+/[^/]+?))(?:/(.+?))?',
	capture: ['projectId', 'applicationName', 'branch'],
	}
	}

Based on the dialog in #2076, my sense is that there's two different types of build status we support from Wercker that require two different types of input (one an ID and the other the user/app name combo).

I'm thinking it might be easiest to split these in two, at least the service route definitions, with a base class/reusable functions for all the common bits.

Does that sound reasonable?

[chris48s]

There's an explanation of why splitting it is hard at #2279 (comment) Once you split them into 2 services, we can't control the order the routes get matched in.

That said, as a related issue, what we're doing on the wercker badge is also a bit strange anyway (see point 3 on #2103 ). One of the routes that exists does an unexpected thing for legacy compatibility reasons.

At the time we did that, we had no idea how many users might be relying on the wercker badges, but now we have stats we know that we've served less than 1,000 total requests for the wercker badges in the last month.

Given all that, I'd be happy to:

• re-organise the routes for wercker so we can implement them all unambiguously with patterns
• make the URLs match the content in all cases
• set up redirects as far as possible
• accept some badges are going to break for a small number of users

[paulmelnikow]

Another of these where we're still using a format is Travis. We're using a negative lookahead to prevent matching php-v, along with an optional domain component. I'd suggest we resolve this one by making the domain org|com required, and adding a redirector with the legacy format.