Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert a format to pattern in [githubpackagejson] #3660

Merged
merged 2 commits into from
Jul 7, 2019
Merged

Convert a format to pattern in [githubpackagejson] #3660

merged 2 commits into from
Jul 7, 2019

Conversation

paulmelnikow
Copy link
Member

This now relies on the order in which these are registered, though that seems okay. Exporting them as an array guarantees that.

Ref #3329

@paulmelnikow
Convert a format to pattern in [githubpackagejson]
1c91721 
This now relies on the order in which these are registered, though that seems okay. Exporting them as an array guarantees that.

Ref #3329
@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Jul 6, 2019
@shields-cd shields-cd temporarily deployed to shields-staging-pr-3660 July 6, 2019 23:45 Inactive
@shields-ci
Copy link

shields-ci commented Jul 6, 2019 •
edited
Loading

Warnings
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 4c62679

PyvesB
PyvesB approved these changes Jul 7, 2019
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paulmelnikow paulmelnikow merged commit 9b6a51b into master Jul 7, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the pattern-dynamic-github branch July 7, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulmelnikow @shields-ci @PyvesB @shields-cd