You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There were a couple bugs in that which are being patched in #2730 though there's some outstanding work that would leave this in a cleaner shape. I wanted to capture it here and hash out what ought to be done, then maybe open issues for the smaller pieces.
It should be possible to configure more than one static token, for self-hosting. Maybe this would involve changing GITHUB_TOKEN to GITHUB_TOKENS.
Dynamic tokens should be configurable. When that's turned off, token persistence and the token endpoint should be turned off.
However the pool itself could be used all the time; there's not a big advantage in turning that off when it doesn't need to be used.
This code isn't being run during tests, though let's fix that later as part of #2733. Specifically:
> However _the pool itself_ could be used all the time; there's not a big advantage in turning that off when it doesn't need to be used.
Fix#2728
The GitHub auth code has been refactored in a major effort which started with fixing #1118 and #1119 in #1205, and continued in #1736, #1812, #1813, #1861, #1862, #1906, #1939, #2021, #2253, and #2400. The last of that is finally merged. 😌
There were a couple bugs in that which are being patched in #2730 though there's some outstanding work that would leave this in a cleaner shape. I wanted to capture it here and hash out what ought to be done, then maybe open issues for the smaller pieces.
GITHUB_TOKEN
toGITHUB_TOKENS
.The text was updated successfully, but these errors were encountered: