Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up the GitHub auth #2733

Open
paulmelnikow opened this issue Jan 11, 2019 · 0 comments
Open

Cleaning up the GitHub auth #2733

paulmelnikow opened this issue Jan 11, 2019 · 0 comments
Labels
core Server, BaseService, GitHub auth, Shared helpers developer-experience Dev tooling, test framework, and CI

Comments

@paulmelnikow
Copy link
Member

paulmelnikow commented Jan 11, 2019

The GitHub auth code has been refactored in a major effort which started with fixing #1118 and #1119 in #1205, and continued in #1736, #1812, #1813, #1861, #1862, #1906, #1939, #2021, #2253, and #2400. The last of that is finally merged. 😌

There were a couple bugs in that which are being patched in #2730 though there's some outstanding work that would leave this in a cleaner shape. I wanted to capture it here and hash out what ought to be done, then maybe open issues for the smaller pieces.

  1. It should be possible to configure more than one static token, for self-hosting. Maybe this would involve changing GITHUB_TOKEN to GITHUB_TOKENS.
  2. Dynamic tokens should be configurable. When that's turned off, token persistence and the token endpoint should be turned off.
  3. However the pool itself could be used all the time; there's not a big advantage in turning that off when it doesn't need to be used.
  4. We should make sure it's possible to run GitHub badges without a token, up to the unauthenticated limit. (All GitHub badges throw error with no token set #2754)
@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth, Shared helpers label Jan 11, 2019
@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Jan 11, 2019
paulmelnikow added a commit that referenced this issue Jan 11, 2019
This code isn't being run during tests, though let's fix that later as part of #2733. Specifically:

> However _the pool itself_ could be used all the time; there's not a big advantage in turning that off when it doesn't need to be used.

Fix #2728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth, Shared helpers developer-experience Dev tooling, test framework, and CI
Projects
None yet
Development

No branches or pull requests

1 participant