TokenPool: Add debug logging helper + return correct error #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slice another sliver from #1205.
paulmelnikow
added
core
Generated by 🚫 dangerJS |
paulmelnikow
changed the title
paulmelnikow
commented
Nov 27, 2018
| while ( | ||
| !this.priorityQueue.isEmpty() && | ||
| (next = this.priorityQueue.peek()) | ||
| ) { |
There was a problem hiding this comment.
This is the bug fix ^^
| context('when empty', function() { | ||
| it('next() should return the expected error', function() { | ||
| const tokenPool = new TokenPool() | ||
| expect(() => tokenPool.next()).to.throw('Token pool is exhausted') |
There was a problem hiding this comment.
Previously the error was Priority queue is empty, which is incorrect.
9 tasks
paulmelnikow
force-pushed
the
token-pool-debugging
branch
from
798b5fd
to
c93dc1e
Compare
PyvesB
reviewed
Dec 1, 2018
lib/token-pool.spec.js
Outdated
| }) | ||
| }) | ||
|
|
||
| context('with sanitize: true', function() { |
PyvesB
approved these changes
Dec 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slice another sliver from #1205.