Crash in modified GitHub auth

[paulmelnikow]

Are you experiencing an issue with...

• shields.io

🪲 Description

Post deploy of #1205:

Error: Vendor hook error:,Error: usesRemaining must be an integer
    at Token.update (/home/m/shields/lib/token-pool.js:65:13)
    at GithubApiProvider.updateToken (/home/m/shields/services/github/github-api-provider.js:57:11)
    at request (/home/m/shields/services/github/github-api-provider.js:109:16)
    at Request.request [as _callback] (/home/m/shields/lib/request-handler.js:182:9)
    at Request.self.callback (/home/m/shields/node_modules/request/request.js:185:22)
    at Request.emit (events.js:160:13)
    at Request.<anonymous> (/home/m/shields/node_modules/request/request.js:1161:10)
    at Request.emit (events.js:160:13)
    at IncomingMessage.<anonymous> (/home/m/shields/node_modules/request/request.js:1083:12)
    at Object.onceWrapper (events.js:255:19)
    at IncomingMessage.emit (events.js:165:20)
    at endReadableNT (_stream_readable.js:1101:12)
    at process._tickCallback (internal/process/next_tick.js:152:19)

[paulmelnikow]

Still happening after deploy of #2730, though not on every badge.

Error: Vendor hook error:,Error: usesRemaining must be an integer
    at Token.update (/home/m/shields/lib/token-pool.js:65:13)
    at GithubApiProvider.updateToken (/home/m/shields/services/github/github-api-provider.js:87:11)
    at request (/home/m/shields/services/github/github-api-provider.js:140:18)
    at Request.request [as _callback] (/home/m/shields/lib/request-handler.js:182:9)
    at Request.self.callback (/home/m/shields/node_modules/request/request.js:185:22)
    at Request.emit (events.js:160:13)
    at Request.<anonymous> (/home/m/shields/node_modules/request/request.js:1161:10)
    at Request.emit (events.js:160:13)
    at IncomingMessage.<anonymous> (/home/m/shields/node_modules/request/request.js:1083:12)
    at Object.onceWrapper (events.js:255:19)
    at IncomingMessage.emit (events.js:165:20)
    at endReadableNT (_stream_readable.js:1101:12)
    at process._tickCallback (internal/process/next_tick.js:152:19)

[calebcartwright]

Does that mean that some GH badges are working but not others?

[paulmelnikow]

Yea. You can try on https://s0.shields-server.com/index.html. When I try loading them, they seem fine. Also e.g. curl --insecure https://s0.shields-server.com/github/release-date-pre/Cockatrice/Cockatrice.json is working.

I actually haven't found one that doesn't work, though I'm seeing the errors in Sentry.

[calebcartwright]

Yeah I just ran through several too, no issues in the UI either, badges rendering lovely

[calebcartwright]

I don't suppose there's any chance of a delay in Sentry (i.e. any chance those errors are from a few minutes before the #2730 deploy)?

[paulmelnikow]

I was suspicious of that too. Though they didn't start appearing until the deploy, and the line numbers seem to correspond. I am seeing this in the Sentry UI, though, and I'm not sure what it means:

[paulmelnikow]

Sentry issue: SHIELDS-22

[calebcartwright]

That link took me into a sentry sign up page so I'm guessing that in addition to me not having a sentry account that I probably don't have access either?

[paulmelnikow]

Right. I think more of the maintainers should have access, though. It's more than I should carry on my own.

[paulmelnikow]

Okay, #2736 is the fix. The problem is the badges that use search quota. rateLimit for those is 25, and 0.25 times that is, indeed, not an integer. It also explains why most of the GitHub badges are working fine.

[calebcartwright]

Good find!

[paulmelnikow]

Think this is fixed! No new errors in the last minute or so. The search badge is working, too, though I didn't actually try it pre-deploy.