e2e: Switch to testnet fixture #1709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
e2e-address-allocation
branch
8 times, most recently
from
f8d41ab to
6b9a223
Compare
This was referenced Jul 11, 2023
marun
force-pushed
the
e2e-address-allocation
branch
from
6b9a223 to
282ed56
Compare
marun
force-pushed
the
e2e-address-allocation
branch
4 times, most recently
from
c32cd2c to
a47f45a
Compare
marun
changed the title
marun
changed the title
marun
force-pushed
the
e2e-address-allocation
branch
12 times, most recently
from
5c01cfa to
e10b764
Compare
marun
force-pushed
the
e2e-address-allocation
branch
from
04eecaa to
bb20c3e
Compare
darioush
approved these changes
Aug 8, 2023
hexfusion
approved these changes
Aug 8, 2023
marun
force-pushed
the
e2e-address-allocation
branch
from
7c85f13 to
19ccc50
Compare
Signed-off-by: marun <maru.newby@avalabs.org>
| for { | ||
| _, reserved := constants.NetworkIDToNetworkName[networkID] | ||
| if reserved { | ||
| networkID++ |
Comment on lines
+62
to
+64
| WithTimeout(e2e.DefaultTimeout). | ||
| WithPolling(e2e.DefaultPollingInterval). | ||
| Should(gomega.BeTrue(), "The cluster is generating ongoing blocks. Is this test being run in parallel?") |
There was a problem hiding this comment.
I spent like 20m understanding how this works lol.
There was a problem hiding this comment.
Yeah, I'm not a huge fan of how ginkgo does this but I wanted to use ginkgo for consistency. I'm writing new e2e tests with testify, and at some point we can rewrite existing tests to also use it.
StephenButtolph
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This change updates the e2e test suite to use the new testnet fixture introduced in #1700. The new fixture is simpler and maintained in tree to better enable e2e test development.
As part of this change, the fixture's funded keys are allocated at-most-once to tests to avoid the following problems:
How this works
How this was tested
./scripts/tests.e2e.shwas updated to run tests in parallel and in random order. This revealed the requirement to tag the virtuous tests asSerialto avoid skipping on conflict with other tests../scripts/tests.e2e.persistent.shwas updated to runtests.e2e.shagainst a persistent networkTODO