E2E tests -- use appropriate timeouts #1851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
approved these changes
Aug 14, 2023
|
As per a slack conversation with @StephenButtolph, we probably want to switch to a long general-purpose timeout rather than shorter operation-specific timeouts. Yes, it can slow down discovery of actual failure, but it avoids having to update timeouts in response to changes in expected timing (in this case enabling the race detector). e.g. #1709 switches the permissionless subnet testing to use e2e.DefaultTImeout which is 2m. |
marun
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Saw a flake in an E2E test. It seems like we're using the wallet creation timeout in some places we should be using the tx acceptance timeout.
How this works
Use tx acceptance timeout instead of wallet creation timeout as needed
How this was tested
N/A