e2e: Migrate duplicate node id test from kurtosis #1573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
e2e-duplicate-nodes
branch
from
048e629 to
1b7b9dd
Compare
marun
force-pushed
the
e2e-duplicate-nodes
branch
from
1b7b9dd to
3165264
Compare
|
Rebased on #1700. This PR won't be ready for review until that merges. |
marun
force-pushed
the
e2e-duplicate-nodes
branch
from
3165264 to
1b97de2
Compare
|
Rebased on #1709 |
marun
force-pushed
the
e2e-duplicate-nodes
branch
2 times, most recently
from
303468b to
88d3764
Compare
marun
changed the title
marun
force-pushed
the
e2e-duplicate-nodes
branch
2 times, most recently
from
cb752ae to
2429fd9
Compare
marun
force-pushed
the
e2e-duplicate-nodes
branch
from
2429fd9 to
7190112
Compare
marun
force-pushed
the
e2e-duplicate-nodes
branch
16 times, most recently
from
1d60ff1 to
f9b6da9
Compare
|
Rebased |
1 task
hexfusion
approved these changes
Aug 20, 2023
marun
force-pushed
the
e2e-duplicate-nodes
branch
2 times, most recently
from
9def445 to
6abbd1a
Compare
Closed
16 tasks
marun
force-pushed
the
e2e-duplicate-nodes
branch
from
78bb4fe to
8ff5e04
Compare
StephenButtolph
approved these changes
Aug 26, 2023
- rename 'temporary node' to 'ephemeral node' for clarity - ensure ephemeral node data is stored in the network path and not removed on teardown to allow archiving in CI to collect all data for a test run. - Remove `Node.Remove()` method since it is not being used
marun
force-pushed
the
e2e-duplicate-nodes
branch
from
250d74d to
2773caa
Compare
marun
force-pushed
the
e2e-duplicate-nodes
branch
from
e018764 to
80b94e1
Compare
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: marun <maru.newby@avalabs.org>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fulfills one of the requirements for #1547 (migration of Kurtosis tests)
How this works
How this was tested
Ran ./scripts/test.e2e.sh
TODO