Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perception_utils): fix -Werror=reorder #4369

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 22, 2023

Description

/home/satoshi/pilot-auto/install/perception_utils/include/perception_utils/prime_synchronizer.hpp:348:10: error: ‘perception_utils::PrimeSynchronizer<tier4_perception_msgs::msg::TrafficSignalArray_<std::allocator<void> >, tier4_perception_msgs::msg::TrafficLightRoiArray_<std::allocator<void> >, sensor_msgs::msg::CameraInfo_<std::allocator<void> >, sensor_msgs::msg::PointCloud2_<std::allocator<void> > >::max_delay
_t_’ will be initialized after [-Werror=reorder]                                                                                                                                                                                                                                                                                                                                                                                
  348 |   double max_delay_t_;                                                                                                                                                                                                                                                                                                                                                                                                  
      |          ^~~~~~~~~~~~                                                                                                                                                                                                                                                                                                                                                                                                   
/home/satoshi/pilot-auto/install/perception_utils/include/perception_utils/prime_synchronizer.hpp:344:10: error:   ‘double perception_utils::PrimeSynchronizer<tier4_perception_msgs::msg::TrafficSignalArray_<std::allocator<void> >, tier4_perception_msgs::msg::TrafficLightRoiArray_<std::allocator<void> >, sensor_msgs::msg::CameraInfo_<std::allocator<void> >, sensor_msgs::msg::PointCloud2_<std::allocator<void> > >::
max_wait_t_’ [-Werror=reorder]                                                                                                                                                                                                                                                                                                                                                                                                  
  344 |   double max_wait_t_;                                                                                                                                                                                                                                                                                                                                                                                                   
      |          ^~~~~~~~~~~                                                                                                                                                                                                                                                                                                                                                                                                    
/home/satoshi/pilot-auto/install/perception_utils/include/perception_utils/prime_synchronizer.hpp:72:3: error:   when initialized here [-Werror=reorder]                                                                                                                                                                                                                                                                        
   72 |   PrimeSynchronizer(                                                                                                                                                                                                                                                                                                                                                                                                    
      |   ^~~~~~~~~~~~~~~~~

Tests performed

Nothing.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jul 22, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review July 22, 2023 06:42
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 23, 2023
@satoshi-ota satoshi-ota enabled auto-merge (squash) July 23, 2023 02:57
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cbaaa69) 15.05% compared to head (15eb981) 15.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4369   +/-   ##
=======================================
  Coverage   15.05%   15.05%           
=======================================
  Files        1508     1508           
  Lines      103791   103791           
  Branches    31709    31709           
=======================================
  Hits        15629    15629           
  Misses      71137    71137           
  Partials    17025    17025           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.05% <ø> (ø) Carriedforward from cbaaa69

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota merged commit 10d2ad5 into autowarefoundation:main Jul 23, 2023
@satoshi-ota satoshi-ota deleted the fix/suppress-werror branch July 23, 2023 10:25
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jul 24, 2023
fix(perception_utils): fix

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants