feat(tier4_state_rviz_plugin): add API monitoring for Routing, Localization and Motion #2436

h-ohta · 2022-12-02T09:19:11Z

Description

add API monitoring for Routing, Localization and Motion
refactoring

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

codecov · 2022-12-02T10:12:11Z

Codecov Report

Base: 10.60% // Head: 10.57% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (da8d55e) compared to base (0f37fdb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2436      +/-   ##
==========================================
- Coverage   10.60%   10.57%   -0.04%     
==========================================
  Files        1265     1266       +1     
  Lines       87380    87577     +197     
  Branches    20852    20852              
==========================================
- Hits         9270     9260      -10     
- Misses      68250    68455     +205     
- Partials     9860     9862       +2

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`10.59% <0.00%> (-0.02%)`	⬇️	Carriedforward from cda15ac

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...er4_state_rviz_plugin/src/autoware_state_panel.cpp	`0.00% <0.00%> (ø)`
...er4_state_rviz_plugin/src/autoware_state_panel.hpp	`0.00% <0.00%> (ø)`
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp	`64.15% <0.00%> (-18.87%)`	⬇️
...erception/traffic_light_classifier/src/nodelet.cpp	`0.00% <0.00%> (ø)`
...in_autogen/UVLADIE3JM/moc_autoware_state_panel.cpp	`0.00% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

common/tier4_state_rviz_plugin/src/autoware_state_panel.cpp

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

isamu-takagi

LGTM

…zation and Motion (autowarefoundation#2436) * feat: add viz for routing API * feat: add motion and localiation Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * some refactoring * add comment * add vertical align Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: in transition * fix: setupLabel -> updateLabel * add memory Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * fix pre commit Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * ci(pre-commit): autofix Signed-off-by: h-ohta <hiroki.ota@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…zation and Motion (autowarefoundation#2436) * feat: add viz for routing API * feat: add motion and localiation Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * some refactoring * add comment * add vertical align Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: in transition * fix: setupLabel -> updateLabel * add memory Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * fix pre commit Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * ci(pre-commit): autofix Signed-off-by: h-ohta <hiroki.ota@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>

…zation and Motion (autowarefoundation#2436) * feat: add viz for routing API * feat: add motion and localiation Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * some refactoring * add comment * add vertical align Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: in transition * fix: setupLabel -> updateLabel * add memory Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * fix pre commit Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * ci(pre-commit): autofix Signed-off-by: h-ohta <hiroki.ota@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>

h-ohta added 2 commits December 2, 2022 18:17

feat: add viz for routing API

b9adb95

feat: add motion and localiation

b493094

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Dec 2, 2022

some refactoring

27ec23b

h-ohta force-pushed the feat/adapi_addition2 branch from ca51b5c to 27ec23b Compare December 2, 2022 09:56

add comment

2e41163

h-ohta requested a review from taikitanaka3 December 2, 2022 10:00

h-ohta marked this pull request as ready for review December 2, 2022 10:00

h-ohta requested review from isamu-takagi and a team as code owners December 2, 2022 10:00

h-ohta changed the title ~~feat(tier4_state_rviz_plugin): Add API monitoring for Routing, Localization and Motion~~ feat(tier4_state_rviz_plugin): Add API monitoring for Routing and Localization and Motion Dec 2, 2022

h-ohta changed the title ~~feat(tier4_state_rviz_plugin): Add API monitoring for Routing and Localization and Motion~~ feat(tier4_state_rviz_plugin): Add API monitoring for Routing, Localization and Motion Dec 2, 2022

h-ohta changed the title ~~feat(tier4_state_rviz_plugin): Add API monitoring for Routing, Localization and Motion~~ feat(tier4_state_rviz_plugin): Add some API monitoring Dec 2, 2022

h-ohta changed the title ~~feat(tier4_state_rviz_plugin): Add some API monitoring~~ feat(tier4_state_rviz_plugin): Add some API monitoring Dec 2, 2022

h-ohta changed the title ~~feat(tier4_state_rviz_plugin): Add some API monitoring~~ feat(tier4_state_rviz_plugin): use ADAPI v1 instead of old API Dec 2, 2022

h-ohta changed the title ~~feat(tier4_state_rviz_plugin): use ADAPI v1 instead of old API~~ feat(tier4_state_rviz_plugin): add API monitoring for Routing, Localization and Motion Dec 2, 2022

isamu-takagi reviewed Dec 2, 2022

View reviewed changes

common/tier4_state_rviz_plugin/src/autoware_state_panel.cpp Outdated Show resolved Hide resolved

isamu-takagi and others added 5 commits December 3, 2022 07:43

add vertical align

cda15ac

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

fix: in transition

a050db2

fix: setupLabel -> updateLabel

afab8a1

add memory

a2e9413

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

fix pre commit

896e4cb

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

h-ohta force-pushed the feat/adapi_addition2 branch from 8007574 to 896e4cb Compare December 5, 2022 02:20

ci(pre-commit): autofix

da8d55e

isamu-takagi approved these changes Dec 5, 2022

View reviewed changes

h-ohta merged commit 33be737 into autowarefoundation:main Dec 5, 2022

h-ohta deleted the feat/adapi_addition2 branch December 5, 2022 04:14

tier4-autoware-public-bot bot mentioned this pull request Dec 6, 2022

chore: sync upstream tier4/autoware.universe#198

Merged

TomohitoAndo mentioned this pull request Dec 14, 2022

chore: cherry pick adapi support for rviz state plugin tier4/autoware.universe#208

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tier4_state_rviz_plugin): add API monitoring for Routing, Localization and Motion #2436

feat(tier4_state_rviz_plugin): add API monitoring for Routing, Localization and Motion #2436

h-ohta commented Dec 2, 2022 •

edited

Loading

codecov bot commented Dec 2, 2022 •

edited

Loading

isamu-takagi left a comment

feat(tier4_state_rviz_plugin): add API monitoring for Routing, Localization and Motion #2436

feat(tier4_state_rviz_plugin): add API monitoring for Routing, Localization and Motion #2436

Conversation

h-ohta commented Dec 2, 2022 • edited Loading

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Dec 2, 2022 • edited Loading

Codecov Report

isamu-takagi left a comment

Choose a reason for hiding this comment

h-ohta commented Dec 2, 2022 •

edited

Loading

codecov bot commented Dec 2, 2022 •

edited

Loading