Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_autoware_utils): add pose interpolation function #1097

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jun 14, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Add geometry pose interpolation function to tier4 autoware utils

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #1097 (f65af81) into main (785c8d6) will increase coverage by 0.04%.
The diff coverage is 59.61%.

@@           Coverage Diff            @@
##            main   #1097      +/-   ##
========================================
+ Coverage   8.98%   9.02%   +0.04%     
========================================
  Files       1024    1025       +1     
  Lines      69430   69484      +54     
  Branches   11697   11721      +24     
========================================
+ Hits        6238    6272      +34     
  Misses     58008   58008              
- Partials    5184    5204      +20     
Flag Coverage Δ *Carryforward flag
differential 9.27% <59.61%> (?)
total 8.96% <ø> (ø) Carriedforward from 785c8d6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...autoware_utils/test/src/geometry/test_geometry.cpp 37.11% <50.00%> (+1.74%) ⬆️
...include/tier4_autoware_utils/geometry/geometry.hpp 92.00% <100.00%> (+1.37%) ⬆️
...lude/tier4_autoware_utils/math/unit_conversion.hpp 100.00% <0.00%> (ø)
...planning_evaluator/src/planning_evaluator_node.cpp 38.14% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 785c8d6...f65af81. Read the comment docs.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit 373c91a into autowarefoundation:main Jun 15, 2022
@purewater0901 purewater0901 deleted the feat/add-pose-interpolation branch June 15, 2022 01:46
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
…foundation#1097)

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
boyali referenced this pull request in boyali/autoware.universe Jul 1, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
yn-mrse referenced this pull request in tier4/autoware.universe Jun 20, 2023
Signed-off-by: yutaka <purewater0901@gmail.com>
yn-mrse referenced this pull request in tier4/autoware.universe Jun 20, 2023
Signed-off-by: yutaka <purewater0901@gmail.com>
yn-mrse referenced this pull request in tier4/autoware.universe Jun 21, 2023
#1100, #1126) (#592)

* feat(tier4_autoware_utils): add pose interpolation function (#1097)

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(tier4_autoware_utils): add new orientation calculation (#1126)

* feat(tier4_autoware_utils): add new orientation calculation

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix format

* feat(tier4_autoware_utils): add point interpolation function (#1100)

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
Co-authored-by: Yutaka Shimizu <43805014+purewater0901@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants