fix(arr): make arr_id_cache expiry timezone-independent

[nitrobass24]

Summary

ArrIDCacheStore's cache was silently disabled for anyone running qui in a non-UTC timezone. Set stored expires_at as a local-time time.Time, while Get / CleanupExpired / CountValid compared it against SQLite's CURRENT_TIMESTAMP (UTC). The modernc.org/sqlite driver serializes the bound time.Time as a string whose lexical ordering against the CURRENT_TIMESTAMP UTC string only matches chronological order when the process runs in UTC. In any other timezone, Get returned sql.ErrNoRows for a freshly written, unexpired entry — so every ARR title lookup hit the upstream HTTP endpoint instead of the cache. CI never caught it because GitHub runners default to TZ=UTC.

Fix

Make both sides of every expiry comparison flow through the same driver path as UTC time.Time values:

• SetWithTitles stores time.Now().Add(ttl).UTC().
• Get / CleanupExpired / CountValid compare expires_at > ? (and <= ?) binding time.Now().UTC() instead of CURRENT_TIMESTAMP.

This is dialect-agnostic — the ? placeholder is rebound to $N for Postgres — and needs no migration. It also removes a latent timestamp vs timestamptz coercion that CURRENT_TIMESTAMP caused on Postgres. cached_at is unchanged (it is never used in a comparison).

The sibling torznab_search_cache store uses the same expires_at > CURRENT_TIMESTAMP SQL but is already safe because it stores expires_at in UTC, so it is intentionally left untouched.

Upgrade note

Pre-fix rows written with a local-time expires_at are treated as expired after upgrading. This is a benign one-time cache miss (the entry is re-fetched), not stale or wrong data — no migration required.

Testing

• go test -race -count=1 ./internal/models/ ./internal/services/arr/ passes under both the default TZ and TZ=UTC.
• The two pre-existing arr service tests that failed outside UTC (TestService_LookupExternalIDsUsesNegativeCache, ...KeepsLegacyPositiveCacheWhenAliasHydrationMisses) now pass under TZ=America/Chicago.
• New regression test internal/models/arr_id_cache_test.go pins time.Local to a fixed non-UTC zone so it reproduces on UTC CI runners — verified to fail before this change (sql: no rows in result set) and pass after. Covers positive + negative entries, the expired-entry-unretrievable path, and CountValid/CleanupExpired.
• gofmt, golangci-lint, go vet clean on the changed files; make build succeeds.

Follow-up (not in this PR)

The issue suggested running the suite under a non-UTC TZ in CI to catch this class of bug. This PR's regression test already reproduces it under UTC, but a dedicated non-UTC CI job remains a reasonable separate addition.

Closes #1961

Summary by CodeRabbit

• Bug Fixes

  • Fixed cache expiry handling to work correctly regardless of system timezone settings, ensuring consistent behavior across different server environments.

• Tests

  • Added timezone-specific tests to verify cache operations function properly when the system timezone is non-UTC.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e9abd6a5-f370-4f6c-bb87-ac8eece4f8e2

📥 Commits

Reviewing files that changed from the base of the PR and between 719866b and f0d1dbe.

📒 Files selected for processing (2)

• internal/models/arr_id_cache.go
• internal/models/arr_id_cache_test.go

---

Walkthrough

The PR fixes a timezone-dependent bug in ArrIDCacheStore where cache lookups fail in non-UTC environments. Implementation switches from SQL CURRENT_TIMESTAMP to parameterized UTC time binding in Get, SetWithTitles, CleanupExpired, and CountValid. New regression tests verify correct behavior under non-UTC time.Local.

Changes

Timezone-Independent Cache Expiry

Layer / File(s)	Summary
Timezone-independent expiry implementation internal/models/arr_id_cache.go	Get, CleanupExpired, CountValid, and SetWithTitles are updated to use UTC-bound parameterized time values instead of SQL CURRENT_TIMESTAMP, ensuring lexical string comparisons behave chronologically regardless of process timezone.
Non-UTC timezone regression tests internal/models/arr_id_cache_test.go	Introduces forceNonUTCLocal helper and three regression tests that verify Get, SetWithTitles, CleanupExpired, CountValid, and negative cache entries all behave correctly when time.Local is non-UTC.

🎯 2 (Simple) | ⏱️ ~12 minutes

🐰 A cache once lost in timezone's night,
Now bound to UTC, shining bright,
In Central, Pacific, or Eastern zone,
The entries are found, never alone!
Tests guard against the shadow of doubt. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(arr): make arr_id_cache expiry timezone-independent' accurately and concisely summarizes the main change—resolving a timezone bug in cache expiry logic.
Linked Issues check	✅ Passed	All coding objectives from issue #1961 are met: timezone-independent expiry logic, bound UTC parameters instead of CURRENT_TIMESTAMP, UTC normalization in Set, regression tests with non-UTC timezone forcing, and no DB migration required.
Out of Scope Changes check	✅ Passed	All changes are scoped to the arr_id_cache expiry timezone fix: modifications to Get/Set/CleanupExpired/CountValid and new regression tests for non-UTC behavior; no unrelated changes present.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/1961-arr-cache-utc

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}