refactor(web): extract useTorrentSelectionDerivations

[nitrobass24]

⚠️ Strict merge order — #1963 decomposition stack

These PRs edit TorrentTableOptimized.tsx sequentially and must be merged strictly in order. Merging out of order will cause conflicts and force rebases of every downstream PR.

Order: #1970 → #1971 → #1973 → #1974 → #1975 → #1976 → #1977 → #1978 → #1980 → #1982

This is PR-05 (position 5). ⛔ Do not merge before #1970, #1971, #1973, and #1974.

---

Summary

Fifth extraction in the TorrentTableOptimized.tsx decomposition (#1963). Pulls the selection-derived values that bulk actions and dialogs depend on into a dedicated hook — and pins the #1925 invariant.

No behavior change — logic relocated verbatim; verified by an adversarial behavior-preservation review.

Extracted — hooks/torrent-table/useTorrentSelectionDerivations.ts

selectedHashes, effectiveSelectionCount, selectedTorrents, selectedTotalSize (+ formatted), the delete-dialog sizes, and the select-all targeting inputs selectAllFilters, selectAllExcludedTargets, selectAllExcludeHashes.

The #1925 pin (the other half)

selectAllFilters ALWAYS combines columnFiltersExpr with filters.expr when both are present — it must NOT adopt the cross-seed early-return that useTorrentTableFilterExpr.combinedFiltersExpr uses (PR-03). A named regression test asserts that with a column filter active and a cross-seed (Hash ==/||) expr, selectAllFilters.expr === "(state == \"downloading\") && (Hash == \"abc\" || Hash == \"def\")". Together with PR-03's opposite assertion, the divergence is now locked from both sides.

Notes

• Visible-row access goes through an injected getVisibleRows() callback (reusing PR-04's SelectionRow shape) so the hook is unit-testable.
• torrentIdentityCounts was intentionally left in the component — it feeds useReactTable's getRowId and must stay before the table (belongs to the later column-wiring PR).

TorrentTableOptimized.tsx drops from 3007 → 2894 lines.

Tests

16 renderHook tests: the #1925 always-combine pin (+ the no-column / no-filter / not-select-all variants), selectedHashes/selectedTorrents resolution (regular + select-all-minus-exclusions), effectiveSelectionCount, selectedTotalSize (sum vs aggregate-minus-excluded), selectAllExcludeHashes (undefined for cross-instance), excluded-targets, and delete-dialog sizing.

Testing

• pnpm test — 445/445 pass (incl. the whole-table smoke test)
• tsc -b clean; test-config typecheck clean
• pnpm lint — new files 0 problems
• pnpm build succeeds
• Adversarial behavior-preservation review passed (incl. the [BUG] Qui deleting more than it should when filtering #1925 invariant)

Summary by CodeRabbit

• Refactor

  • Refactored torrent selection logic for improved code organization and maintainability.

• Tests

  • Added comprehensive test suite for selection derivation functionality, covering regular and select-all modes with various filtering and exclusion scenarios.

[coderabbitai]

Walkthrough

This PR extracts selection-derivation logic from TorrentTableOptimized.tsx into a reusable custom hook useTorrentSelectionDerivations. The hook centralizes calculations for resolved selection hashes, torrents, effective counts, total sizes, select-all filters, and exclusion targeting across regular and select-all modes. Comprehensive tests cover all selection modes and edge cases.

Changes

Selection Derivation Hook

Layer / File(s)	Summary
Hook interface and parameters web/src/hooks/torrent-table/useTorrentSelectionDerivations.ts	UseTorrentSelectionDerivationsParams interface defines the hook's input contract: selection mode, row/torrent data, visible rows, sizes, filters, and cross-instance context.
Selection resolution and effective count web/src/hooks/torrent-table/useTorrentSelectionDerivations.ts, web/src/hooks/torrent-table/__tests__/useTorrentSelectionDerivations.test.ts	Core logic resolves selectedHashes and selectedTorrents from either visible row ids (regular mode) or all sorted torrents minus exclusions (select-all mode); effectiveSelectionCount reflects visible selection length or total-minus-exclusions accordingly; tests verify both modes and exclusion handling.
Size calculations for selection and delete dialogs web/src/hooks/torrent-table/useTorrentSelectionDerivations.ts, web/src/hooks/torrent-table/__tests__/useTorrentSelectionDerivations.test.ts	selectedTotalSize sums selected torrents in regular mode and uses aggregate stats.totalSize (minus excluded sizes) in select-all mode; deleteDialogTotalSize prefers selected total in select-all and falls back to context torrents; both return formatted byte strings; tests cover regular/select-all modes with and without exclusions.
Filter and exclusion targeting web/src/hooks/torrent-table/useTorrentSelectionDerivations.ts, web/src/hooks/torrent-table/__tests__/useTorrentSelectionDerivations.test.ts	selectAllFilters combines columnFiltersExpr and filters.expr via && only in select-all mode; selectAllExcludedTargets and selectAllExcludeHashes build action targets for excluded torrents with cross-instance suppression; tests verify filter combination (including cross-seed regression) and exclusion derivations.
Component refactoring to use new hook web/src/components/torrents/TorrentTableOptimized.tsx	TorrentTableOptimized imports useTorrentSelectionDerivations and destructures all selection-derived values from the hook, removing inline useMemo blocks for selectedHashes, selectedTorrents, effectiveSelectionCount, sizes, filters, and exclusion targets; getTotalSize removed from torrent-utils imports.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related issues

• reactor: decompose TorrentTableOptimized.tsx into testable seams #1963: The extraction of selection-derivation logic into useTorrentSelectionDerivations and preservation of selectAllFilters semantics directly implement the requested seam decomposition and bulk-action alignment.

Possibly related PRs

• autobrr/qui#530: Both modify selection state derivation/maintenance in TorrentTableOptimized.tsx.
• autobrr/qui#1926: Both move selectAllFilters construction and explicitly combine columnFiltersExpr with filters.expr via &&.
• autobrr/qui#1455: Both adjust selection state and behavior in TorrentTableOptimized.tsx.

Suggested labels

refactor, web, torrent, tests

Suggested reviewers

• s0up4200
• zze0s

Poem

🐰 Hops through selection states so clear,
Derived values now consolidate here,
Hook logic dances, filters combine,
Select-all and regular, aligned just fine!
Tests verify every mode with care,
Selection refactored with such flair! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'refactor(web): extract useTorrentSelectionDerivations' accurately and specifically describes the main change: extracting selection derivation logic into a new hook.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/1963-pr05-selection-derivations

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}