feat: UniversalProposal for produceBlockV3 #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obol-bulldozer bot
pushed a commit
to ObolNetwork/charon
that referenced
this pull request
Mar 1, 2024
Integrated the forked version of go-eth2-client that supporting UniversalProposal interface. The changes for go-eth2-client can be found here: attestantio/go-eth2-client#109 category: feature ticket: #2749
|
Hi thanks for the PR. Internally we have been working on unifying the underlying blinded and non-blinded proposal flows, and have an alternate pr #116 Please could you take a look at this and let me know if it meets your requirements? Thank you. |
Thank you @mcdee ! |
|
Closed in favor of @mcdee 's implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces UniversalProposal to support produceBlockV3 endpoint.
When I created the PR, I realized there is another one for the same purpose: #107 done by @y0sher just a couple days ago.
In my implementation I did not deprecate the v2 endpoints, I believe they may co-exist safely in go-eth2-client project.
If you want to proceed with the other implementation, that's fine, just leave a note in the comment so I can close the PR.
cc @mcdee