feat: implement produceBlockV3
#107
Conversation
| import "github.com/attestantio/go-eth2-client/spec/phase0" | ||
|
|
||
| // V3ProposalOpts are the options for obtaining v3 proposals. | ||
| type V3ProposalOpts struct { |
There was a problem hiding this comment.
This seems missing builder_boost_factor param.
There was a problem hiding this comment.
thanks, it was actually added yesterday to the spec ethereum/beacon-APIs#431, after I did the PR. will do the changes soon.
| // VersionedV3Proposal contains a versioned generic beacon block. | ||
| type VersionedV3Proposal struct { | ||
| Version spec.DataVersion | ||
| ExecutionPayloadBlinded bool |
There was a problem hiding this comment.
These should be automatically reflected in Metadata. Maybe we don't need to make them first-class citizens?
There was a problem hiding this comment.
Version is also in metadata but it is showed up in the struct, I took the example of how @mcdee did it with version. anyway lets wait for his review.
|
Hi thanks for the PR. Internally we have been working on unifying the underlying blinded and non-blinded proposal flows, and have an alternate pr #116 Please could you take a look at this and let me know if it meets your requirements? Thank you. |
|
Functionality now available in the library. |
Description
Implements produceBlockV3 according to the ethereum beacon spec.
Why
produceBlockV2 is deprecated according to the ethereum beacon specs. the only correct way to get full blocks right now is using
produceBlockV3.Open questions
produceBlockV2to support legacy api endpoint? (I did for now)V3Proposalfor now, but I thought it's best to consult with you. (prysm for example called itGenericVersionedBlock@mcdee your review appreciated