Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: integrating go-eth2-client for for v3 endpoint #2913

Merged
merged 14 commits into from
Mar 1, 2024

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Feb 28, 2024

Integrated the forked version of go-eth2-client that supporting UniversalProposal interface.

The changes for go-eth2-client can be found here: attestantio/go-eth2-client#109

category: feature
ticket: #2749

go.mod Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 55.18672% with 108 lines in your changes are missing coverage. Please review.

Project coverage is 53.65%. Comparing base (314d11f) to head (f568d72).

Files Patch % Lines
core/dutydb/memory.go 74.41% 16 Missing and 6 partials ⚠️
core/fetcher/fetcher.go 65.57% 14 Missing and 7 partials ⚠️
core/unsigneddata.go 52.27% 15 Missing and 6 partials ⚠️
app/eth2wrap/eth2wrap_gen.go 0.00% 19 Missing ⚠️
testutil/beaconmock/options.go 0.00% 13 Missing ⚠️
testutil/beaconmock/beaconmock.go 0.00% 6 Missing ⚠️
testutil/beaconmock/beaconmock_fuzz.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2913    +/-   ##
========================================
  Coverage   53.65%   53.65%            
========================================
  Files         200      200            
  Lines       28229    28431   +202     
========================================
+ Hits        15146    15255   +109     
- Misses      11214    11283    +69     
- Partials     1869     1893    +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.1% Duplication on New Code

See analysis details on SonarCloud

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Mar 1, 2024
@obol-bulldozer obol-bulldozer bot merged commit 9a9e065 into main Mar 1, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/v3e-model branch March 1, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants