Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Update csharp.cson, fix converter paths #123

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Update csharp.cson, fix converter paths #123

merged 2 commits into from
Aug 28, 2018

Conversation

worldbeater
Copy link
Contributor

@worldbeater worldbeater commented Aug 28, 2018

Description of the Change

As you know, language-csharp grammar that is used by both Atom and Github comes from upstream. So this PR updates the grammar as there were a lot of fixes and improvements since the grammar was updated last time (dotnet/csharp-tmLanguage#114 dotnet/csharp-tmLanguage#132 dotnet/csharp-tmLanguage#113 etc.)

Python script from scripts/ folder was used to keep PCRE support, it removed dashes from group names. Manual fixes were applied according to these commits: 3b93970 15df170 17f89b8 (GitHub highlighter needs them)

Before

// Here used to be bad highlighting, but now 
// changes are merged and the code looks OK!
Span<int> arr = stackalloc [] {1, 2, 3};
static void M(in S arg);
public ref struct RefStruct { }

After

C# language syntax highlighting is improved and now supports ref struct, stackalloc, etc.

image

Possible Drawbacks

None.

@damieng damieng self-requested a review August 28, 2018 21:11
Copy link
Contributor

@damieng damieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice piece of work thanks @worldbeater !

@worldbeater
Copy link
Contributor Author

You are welcome @damieng! And thank you for reviewing this 🥇

@damieng damieng merged commit e26364f into atom:master Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants