Skip to content

Highlight stackalloc keyword #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Highlight stackalloc keyword #132

merged 2 commits into from
Aug 28, 2018

Conversation

worldbeater
Copy link
Contributor

@worldbeater worldbeater commented Aug 27, 2018

Hi. You know, there is a keyword in C# language named stackalloc. This keyword doesn't get highlighted properly in Visual Studio Code editor and on Github. Both services highly depend on csharp-tmLanguage, so let's improve them. This PR brings support for stackalloc keyword highlighting! Thanks @nestquik for reviewing this.

@worldbeater worldbeater reopened this Aug 27, 2018
Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you could add a test?

@worldbeater
Copy link
Contributor Author

Sure. Will need some time.

@DustinCampbell
Copy link
Member

Cool. It should be easy to add. Just follow the pattern in https://github.com/dotnet/csharp-tmLanguage/blob/master/test/expressions.tests.ts.

@worldbeater
Copy link
Contributor Author

@DustinCampbell here you are. 👍

Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@DustinCampbell DustinCampbell merged commit 822c147 into dotnet:master Aug 28, 2018
@worldbeater worldbeater deleted the patch-1 branch August 28, 2018 19:11
aeschli pushed a commit to microsoft/vscode that referenced this pull request Sep 17, 2018
* Adds support for the `stackalloc` keyword.
[csharp-tmLanguage#132](dotnet/csharp-tmLanguage#132)
_(Contributed by [@worldbeater](https://github.com/worldbeater))_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants