Skip to content

Add support for ref struct, ref readonly locals/returns #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 10, 2018

Conversation

idafi
Copy link

@idafi idafi commented May 7, 2018

No description provided.

Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small nit if you don't mind.

@@ -2360,6 +2362,9 @@ repository:
ref-modifier:
name: storage.modifier.cs
match: \b(ref)\b
readonly-modifier:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a line break before this new rule to be consistent with the rest of the grammar?

@idafi
Copy link
Author

idafi commented May 9, 2018

sure; there you go

@DustinCampbell
Copy link
Member

Thanks!

@DustinCampbell DustinCampbell merged commit 25d7b2e into dotnet:master May 10, 2018
DustinCampbell added a commit to DustinCampbell/vscode that referenced this pull request May 10, 2018
This update adds support for ref structs, and ref readonly locals and return types. Contributed by
[@idafi](https://github.com/idafi) with dotnet/csharp-tmLanguage#114.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants