[red-knot] mdtest runner: include stderr for crashing tests - #15644
Merged
Conversation
sharkdp
requested review from
AlexWaygood,
MichaReiser and
carljm
as code owners
January 21, 2025 14:54
sharkdp
commented
Jan 21, 2025
| # Skip 'cargo test' boilerplate at the end | ||
| break | ||
| self._print_trimmed_cargo_test_output( | ||
| output.stdout + output.stderr, test_name |
Contributor
Author
There was a problem hiding this comment.
output.stdout + output.stderr is the only relevant change. I just moved some code into a separate function.
AlexWaygood
approved these changes
Jan 21, 2025
Contributor
|
dcreager
added a commit
that referenced
this pull request
Jan 21, 2025
* main: Separate grouped and ungrouped nodes more clearly in AST generator (#15646) [`flake8-simplify`] Mark fixes as unsafe (`SIM201`, `SIM202`) (#15626) [red-knot] mdtest runner: include stderr for crashing tests (#15644) Change `EnvironmentOptions::venv-path` to `Option<SystemPathBuf>` (#15631) [`flake8-type-checking`] Fix some safe fixes being labeled unsafe (#15638) feat: Update RUF055 to do var == value (#15605)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test executables usually write failure messages (including panics) to stdout, but I just managed to make a mdtest crash with
which is printed to stderr. This test simply appends stderr to stdout (
stderr=subprocess.STDOUTcan not be used withcapture_output)Test Plan
Make sure that the error message is now visible in the output of
uv -q run crates/red_knot_python_semantic/mdtest.py