[flake8-type-checking] Fix some safe fixes being labeled unsafe - #15638
Merged
Conversation
This bug affected the rules `runtime-cast-value` (`TC006`) and `quoted-type-alias` (`TC008`)
Contributor
Author
|
I disovered this bug while working on #15635 |
Contributor
|
Member
|
Thank you. Yeah, |
dcreager
added a commit
that referenced
this pull request
Jan 21, 2025
* main: Separate grouped and ungrouped nodes more clearly in AST generator (#15646) [`flake8-simplify`] Mark fixes as unsafe (`SIM201`, `SIM202`) (#15626) [red-knot] mdtest runner: include stderr for crashing tests (#15644) Change `EnvironmentOptions::venv-path` to `Option<SystemPathBuf>` (#15631) [`flake8-type-checking`] Fix some safe fixes being labeled unsafe (#15638) feat: Update RUF055 to do var == value (#15605)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We were mistakenly using
CommentRanges::has_commentsto determine whether our editswere safe, which sometimes expands the checked range to the end of a line. But in order to
determine safety we need to check exactly the range we're replacing.
This bug affected the rules
runtime-cast-value(TC006) andquoted-type-alias(TC008)although it was very unlikely to be hit for
TC006and forTC008we never hit it because wewere checking the wrong expression.
Test Plan
cargo nextest run